[edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

[Leif Lindholm]

Argh - forgot about the mailing list move, forwarding to current list.

/
   Leif

On Mon, Sep 02, 2019 at 08:02:11PM +0100, Leif Lindholm wrote:
> Hi Bob,
> 
> I was running Ecc today, apparently for the first time since I
> switched to Python3 by default.
> 
> I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=2148 over
> the way Python3 hard codes use of antlr4, whereas it seems to me it
> should be possible to ue Python3 with antlr3 (but not Python2 with
> antlr4).
> 
> However, whilst that issue could be looked at without extreme urgency,
> I am curious as to what is causing the error I am seeing upon working
> around the import failure on my Debian installation (which lacks
> python3-antlr4).
> 
> The output I get when running
> $ Ecc -t /work/git/edk2/EmbeddedPkg/Drivers/DtPlatformDxe/ -s
> 
> is
> 
> ---
> /work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py:409: DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead
>   StartTime = time.clock()
> 11:44:43, Sep.02 2019 [00:00]
> 
> Loading ECC configuration ... done
> Building database for Meta Data File Done!
> Parsing //work/git/edk2/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c
> Traceback (most recent call last):
>   File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main
>     "__main__", mod_spec)
>   File "/usr/lib/python3.7/runpy.py", line 85, in _run_code
>     exec(code, run_globals)
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 410, in <module>
>     Ecc = Ecc()
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 94, in __init__
>     self.DetectOnlyScanDirs()
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 130, in DetectOnlyScanDirs
>     self.BuildDatabase()
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 150, in BuildDatabase
>     c.CollectSourceCodeDataIntoDB(EccGlobalData.gTarget)
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/c.py", line 526, in CollectSourceCodeDataIntoDB
>     collector.ParseFile()
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/CodeFragmentCollector.py", line 517, in ParseFile
>     lexer = CLexer(cStream)
>   File "/work/git/edk2/BaseTools/Source/Python/Ecc/CParser3/CLexer.py", line 147, in __init__
>     Lexer.__init__(self, input)
>   File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 1039, in __init__
>     BaseRecognizer.__init__(self, state)
>   File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 169, in __init__
>     .format(self.api_version))
> RuntimeError: ANTLR version mismatch: The recognizer has been generated with API V0, but this runtime does not support this.
> ---
> 
> Any idea?
> 
> Best Regards,
> 
> Leif
> 
> On Tue, Jan 29, 2019 at 10:06:09AM +0800, Feng, Bob C wrote:
> > v2:
> > The python files under CParser4 are generated by antlr4 and for
> > python3 usage. They have python3 specific syntax, for example
> > the data type declaration for the arguments of a function. That
> > is not compitable with python2. this patch is to remove these syntax.
> > 
> > ECC tool Python3 adaption.
> > 
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Bob Feng <bob.c.feng at intel.com>
> > Cc: Liming Gao <liming.gao at intel.com>
> > ---
> >  BaseTools/Source/Python/Ecc/{ => CParser3}/CLexer.py  |    0
> >  BaseTools/Source/Python/Ecc/{ => CParser3}/CParser.py |    0
> >  BaseTools/Source/Python/Ecc/CParser3/__init__.py      |    0
> >  BaseTools/Source/Python/Ecc/CParser4/C.g4             |  637 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  BaseTools/Source/Python/Ecc/CParser4/CLexer.py        |  632 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  BaseTools/Source/Python/Ecc/CParser4/CListener.py     |  815 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  BaseTools/Source/Python/Ecc/CParser4/CParser.py       | 6279 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  +
> >  BaseTools/Source/Python/Ecc/CParser4/__init__.py      |    0
> >  BaseTools/Source/Python/Ecc/Check.py                  |    4 +-
> >  BaseTools/Source/Python/Ecc/CodeFragmentCollector.py  |   20 +--
> >  BaseTools/Source/Python/Ecc/Configuration.py          |    3 -
> >  BaseTools/Source/Python/Ecc/EccMain.py                |    2 +-
> >  BaseTools/Source/Python/Ecc/EccToolError.py           |    4 +-
> >  BaseTools/Source/Python/Ecc/FileProfile.py            |    2 +-
> >  BaseTools/Source/Python/Ecc/MetaDataParser.py         |    2 +-
> >  BaseTools/Source/Python/Ecc/c.py                      |    6 +-
> >  BaseTools/Source/Python/Ecc/config.ini                |    2 -
> >  17 files changed, 8385 insertions(+), 23 deletions(-)

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46689): https://edk2.groups.io/g/devel/message/46689
Mute This Topic: https://groups.io/mt/33115040/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-