[edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

[Dandan Bi]

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Agyeman, Prince
> Sent: Wednesday, September 4, 2019 2:18 AM
> To: devel at edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman at intel.com>; Sinha, Ankit
> <ankit.sinha at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Kubacki, Michael A
> <michael.a.kubacki at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Bi,
> Dandan <dandan.bi at intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix
> GCC5 build issue
> 
> From: Agyeman <prince.agyeman at intel.com>
> 
> Fixed GPIO table missing curly brackets
> 
> Cc: Ankit Sinha <ankit.sinha at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Michael Kubacki <michael.a.kubacki at intel.com>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> CC: Dandan Bi <dandan.bi at intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman at intel.com>
> ---
>  .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c               | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> index c99b83753f..aa2c770729 100644
> ---
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> +++
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardInitLib/N1xxW
> UGpioTable.c
> @@ -155,7 +155,7 @@ GPIO_INIT_CONFIG mGpioTableN1xxWU[] =
>    {GPIO_SKL_LP_GPP_C16, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutLow,     GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C0_SDA
>    {GPIO_SKL_LP_GPP_C17, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C0_SCL
>    {GPIO_SKL_LP_GPP_C18, {GpioPadModeGpio,    GpioHostOwnGpio,
> GpioDirOut,     GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //I2C1_SDA
> -  {GPIO_SKL_LP_GPP_C19, GpioPadModeGpio,     GpioHostOwnAcpi,
> GpioDirInInv,   GpioOutDefault, GpioIntLevel | GpioIntSci,
> GpioHostDeepReset, GpioTermNone}, //I2C1_SCL
> +  {GPIO_SKL_LP_GPP_C19, {GpioPadModeGpio,     GpioHostOwnAcpi,

One minor comment, please remove one space before " GpioHostOwnAcpi " to make the column aligned before commit the patch.
With this update, Reviewed-by: Dandan Bi <dandan.bi at intel.com>

Thanks,
Dandan
> GpioDirInInv,   GpioOutDefault, GpioIntLevel | GpioIntSci,
> GpioHostDeepReset, GpioTermNone}}, //I2C1_SCL
>    {GPIO_SKL_LP_GPP_C20, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirDefault, GpioOutLow,     GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_RXD
>    {GPIO_SKL_LP_GPP_C21, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirDefault, GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_TXD
>    {GPIO_SKL_LP_GPP_C22, {GpioPadModeNative1, GpioHostOwnDefault,
> GpioDirNone,    GpioOutDefault, GpioIntDis, GpioHostDeepReset,
> GpioTermNone}}, //UART2_RTSB
> --
> 2.19.1.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46731): https://edk2.groups.io/g/devel/message/46731
Mute This Topic: https://groups.io/mt/33129653/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-