[edk2-devel] [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
Chiu, Chasel
chasel.chiu at intel.com
Fri Sep 6 07:01:10 UTC 2019
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159
FSP Dispatch mode will share same stack and heap with
bootloader so we should not reserve separate temporary
ram for FSP.
Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
Test: internal platform can boot with FSP Dispatch mode
with 64KB temporary RAM back.
Cc: Michael Kubacki <michael.a.kubacki at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <liming.gao at intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu at intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 55ae9f47ac..2009bb225a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
@@ -69,10 +69,10 @@
gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
!else
#
- # FSP Dispatch mode will share the same stack with boot loader,
- # here temporary ram size is used by FSP heap and can be smaller
+ # FSP Dispatch mode will share the same stack and heap with boot loader,
+ # no separate temporary ram required by FSP.
#
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0
#
# In FSP Dispatch mode boot loader stack size must be big enough for executing
--
2.13.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#46962): https://edk2.groups.io/g/devel/message/46962
Mute This Topic: https://groups.io/mt/33163786/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list