[edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to gEfiSmmSmramMemoryGuid to fix build error

[Kubacki, Michael A]

The code changes look good.

* The subject should indicate [edk2-platforms] for changes in the edk2-platforms repository.
* PatchCheck.py has the following errors. Please help fix it.

    The commit message format is not valid:
     * First line of commit message (subject line) is too long.
     * Line 3 of commit message is too long.
    https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
    The code passed all checks.

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of David
> Wei
> Sent: Friday, September 13, 2019 2:17 PM
> To: devel at edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu at intel.com>; Gao, Liming <liming.gao at intel.com>;
> Sinha, Ankit <ankit.sinha at intel.com>; Agyeman, Prince
> <prince.agyeman at intel.com>; Kubacki, Michael A
> <michael.a.kubacki at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Subject: [edk2-devel] [PATCH] SimicsOpenBoardPkg: Change to
> gEfiSmmSmramMemoryGuid to fix build error
> 
> MinPlatform PKG now use gEfiSmmSmramMemoryGuid instead of
> gEfiSmmPeiSmramMemoryReserveGuid to build memory HOB.
> SimicsOpenBoardPkg need to update for it accordingly.
> 
> Cc: Hao Wu <hao.a.wu at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Ankit Sinha <ankit.sinha at intel.com>
> Cc: Agyeman Prince <prince.agyeman at intel.com>
> Cc: Kubacki Michael A <michael.a.kubacki at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> 
> Signed-off-by: David Wei <david.y.wei at intel.com>
> ---
>  Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c   | 2 +-
>  Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> index 90e6d1d3cf..ee0eead5a8 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c
> @@ -449,7 +449,7 @@ QemuInitializeRam (
>  	  SmramRanges = 1;
> 
>        Hob.Raw = BuildGuidHob(
> -          &gEfiSmmPeiSmramMemoryReserveGuid,
> +          &gEfiSmmSmramMemoryGuid,
>            BufferSize
>        );
>        ASSERT(Hob.Raw);
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> index ccc7037d75..e466d57e4e 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf
> @@ -39,7 +39,7 @@
> 
>  [Guids]
>    gEfiMemoryTypeInformationGuid
> -  gEfiSmmPeiSmramMemoryReserveGuid              ## CONSUMES
> +  gEfiSmmSmramMemoryGuid              ## CONSUMES
> 
>  [LibraryClasses]
>    BaseLib
> --
> 2.16.2.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47230): https://edk2.groups.io/g/devel/message/47230
Mute This Topic: https://groups.io/mt/34131830/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-