[edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console

[Gao, Zhichao]

> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, September 12, 2019 10:43 AM
> To: Gao, Zhichao <zhichao.gao at intel.com>; devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Ni, Ray <ray.ni at intel.com>
> Subject: RE: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type
> of Terminal console
> 
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Thursday, September 12, 2019 9:02 AM
> > To: devel at edk2.groups.io
> > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray
> > Subject: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type
> of
> > Terminal console
> 
> 
> Hello,
> 
> Entend -> Extend

I would update it later.

> 
> 
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
> >
> > A common terminal console software Putty support various types of
> > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400,
> > VT100+ and SCO. Refer to the link:
> > https://www.ssh.com/ssh/putty/putty-
> manuals/0.68/Chapter4.html#config-
> > funkeys
> >
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Hao A Wu <hao.a.wu at intel.com>
> > Cc: Ray Ni <ray.ni at intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao at intel.com>
> > ---
> >  .../Include/Guid/TerminalConExtendedType.h    | 25
> > +++++++++++++++++++
> >  MdeModulePkg/MdeModulePkg.dec                 |  6 +++++
> >  2 files changed, 31 insertions(+)
> >  create mode 100644
> > MdeModulePkg/Include/Guid/TerminalConExtendedType.h
> >
> > diff --git a/MdeModulePkg/Include/Guid/TerminalConExtendedType.h
> > b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h
> > new file mode 100644
> > index 0000000000..18667413e8
> > --- /dev/null
> > +++ b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h
> > @@ -0,0 +1,25 @@
> > +/** @file
> > +  GUID definition for Linux, XtermR6, Vt400 and SCO terminal type.
> > +
> > +
> > +  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > +  SPDX-License-Identifier: BSD-2-Clause-Patent
> > +
> > +**/
> > +
> > +#ifndef __TERMINAL_CON_EXTENDED_TYPE_H__ #define
> > +__TERMINAL_CON_EXTENDED_TYPE_H__
> > +
> > +#define EDKII_LINUX_MODE_GUID   \
> > +    { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a, 0x9c, 0x9b, 0xe6,
> > +0x81, 0x7c,
> > 0xa5 } }
> > +
> > +#define EDKII_XTERM_R6_GUID     \
> > +    { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab, 0xbe, 0x1b, 0x97,
> > +0xec, 0x7c,
> > 0xcb } }
> > +
> > +#define EDKII_VT400_GUID        \
> > +    { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75, 0x3c, 0x08, 0x6f,
> > +0x6a, 0xa2,
> > 0xbd } }
> > +
> > +#define EDKII_SCO_GUID          \
> > +    { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b, 0xd6, 0x49,
> > +0xe9, 0xe1,
> > 0x5a } }
> > +
> 
> 
> I would suggest to add corresponding GUID declarations just as what has
> been done in:
> 
> MdePkg/Include/Guid/PcAnsi.h
> MdeModulePkg/Include/Guid/TtyTerm.h
> 
> 
> > +#endif
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec index 17beb45235..7528d52fcb
> 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -343,6 +343,12 @@
> >    ## Include/Guid/TtyTerm.h
> >    gEfiTtyTermGuid                = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2,
> > 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
> >
> > +  ## Include/Guid/TerminalConExtendedType.h
> > +  gEdkiiLinuxModeGuid           = { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a,
> > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 } }
> > +  gEdkiiXtermR6Guid             = { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab,
> > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb } }
> > +  gEdkiiVT400Guid               = { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75,
> 0x3c,
> > 0x08, 0x6f, 0x6a, 0xa2, 0xbd } }
> > +  gEdkiiSCOGuid                 = { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b,
> > 0xd6, 0x49, 0xe9, 0xe1, 0x5a } }
> > +
> 
> 
> After this patch, there will be 3 header files that describe different terminal
> modes supported in TerminalDxe driver:
> 
> MdePkg/Include/Guid/PcAnsi.h (PcAnsi, VT100, VT100+, VTUTF8)
> MdeModulePkg/Include/Guid/TtyTerm.h (TtyTerm)
> MdeModulePkg/Include/Guid/TerminalConExtendedType.h (Linux, Xterm
> R6, Vt400, SCO)
> 
> Do we have a plan to add those 5 non-UEFI modes in the UEFI spec?

No, we don't. But that can be taken into consideration.

> 
> If not, I am wondering is it possible to at least merge TtyTerm.h and
> TerminalConExtendedType.h into one file so that we can avoid introducing
> new header files every time new terminal modes are being added.

Great suggestion. For now,  I would merge the TerminatlConExtendedType.h into TtyTerm.h. If the uefi spec would add the new types, then we can put all the types into one header file.

Thanks,
Zhichao

> 
> Best Regards,
> Hao Wu
> 
> 
> >    ## Include/Guid/HiiBootMaintenanceFormset.h
> >    gEfiIfrBootMaintenanceGuid      = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89,
> 0x8a,
> > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
> >
> > --
> > 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47242): https://edk2.groups.io/g/devel/message/47242
Mute This Topic: https://groups.io/mt/34110603/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-