[edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

[Nate DeSimone]

Hi Shenglei,

I don't see how this patch is at all related to the previous version of this patch. Also, you are introducing yet another new bug with this patch. Moreover, this bug is unrelated to the previous bug.

Please take a look at the function TestPointGetAcpi(). With your change added, this function is now broken since Table is a stack variable and it is not being initialized to zero. This function assumes that DumpAcpiXsdt()/DumpAcpiRsdt() will do the initialization to zero on it's behalf, you have broken this assumption with your change.

Both this patch and the previous patch have been made carelessly and I am not impressed.

Thanks,
Nate

-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang at intel.com> 
Sent: Sunday, September 15, 2019 6:09 PM
To: devel at edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Gao, Liming <liming.gao at intel.com>
Subject: [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

Currently there is no check for the parameter OutTable.
So add the logic that return value EFI_INVALID_PARAMETER when the OutTable is NULL.

Cc: Michael Kubacki <michael.a.kubacki at intel.com>
Cc: Chasel Chiu <chasel.chiu at intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
Cc: Liming Gao <liming.gao at intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang at intel.com>
---

v2:Update the copyright and the if...else statement coding style.

 .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c
index 263781a2..83736bf3 100644
--- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c
+++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCh
+++ eckAcpi.c
@@ -1,6 +1,6 @@
 /** @file
 
-Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -610,6 +610,8 @@ DumpAcpiRsdt (
 
   if (OutTable != NULL) {
     *OutTable = NULL;
+  } else{
+    return EFI_INVALID_PARAMETER;
   }
 
   ReturnStatus = EFI_SUCCESS;
@@ -663,6 +665,8 @@ DumpAcpiXsdt (
   
   if (OutTable != NULL) {
     *OutTable = NULL;
+  } else{
+    return EFI_INVALID_PARAMETER;
   }
 
   ReturnStatus = EFI_SUCCESS;
--
2.18.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47298): https://edk2.groups.io/g/devel/message/47298
Mute This Topic: https://groups.io/mt/34159564/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-