[edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types

[Ard Biesheuvel]

On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao at intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
>
> Putty is a very popular terminal tool in windows. So add the whole support
> terminal keyboard type for it. The new introduced type is Linux, XtermR6,
> VT400 and SCO. And enhance the support for VT100+.
> This patch set only add the support of function key. Refer to the link:
> https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys
>
> V2:
> Fix typo.
> Merge the type guid defination into TtyTerm.h.
>

Hello Zhichao,

Since you already pushed the broken patch, you should really be
posting an updated patch with just the fix.

In any case, this makes me wonder how you tested this code, since it
won't even build. Could you elaborate?

-- 
Ard.


> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Hao A Wu <hao.a.wu at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Signed-of-by: Zhichao Gao <zhichao.gao at intel.com>
>
> Zhichao Gao (3):
>   MdeModulePkg: Extend the support keyboard type of Terminal console
>   MdeModulePkg/TerminalDxe: Extend the terminal console support types
>   MdeModulePkg/BM_UI: Add the new terminal types to related menu
>
>  MdeModulePkg/Include/Guid/TtyTerm.h           |  13 +
>  .../BootMaintenanceManager.h                  |  12 +-
>  .../BootMaintenanceManagerStrings.uni         |  10 +-
>  .../ConsoleOption.c                           |  35 +--
>  .../BootMaintenanceManagerUiLib/Data.c        |  16 +-
>  MdeModulePkg/MdeModulePkg.dec                 |   4 +
>  .../Universal/Console/TerminalDxe/Terminal.c  |  17 +-
>  .../Universal/Console/TerminalDxe/Terminal.h  |  37 ++-
>  .../Console/TerminalDxe/TerminalConIn.c       | 281 ++++++++++++++++--
>  .../Console/TerminalDxe/TerminalConOut.c      |   4 +
>  .../Console/TerminalDxe/TerminalDxe.inf       |   6 +-
>  11 files changed, 375 insertions(+), 60 deletions(-)
>
> --
> 2.21.0.windows.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47344): https://edk2.groups.io/g/devel/message/47344
Mute This Topic: https://groups.io/mt/34173528/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-