[edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast

[Liming Gao]

Reviewed-by: Liming Gao <liming.gao at intel.com>

>-----Original Message-----
>From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Wednesday, September 18, 2019 3:49 AM
>To: edk2-devel-groups-io <devel at edk2.groups.io>
>Cc: Gao, Liming <liming.gao at intel.com>; Kinney, Michael D
><michael.d.kinney at intel.com>
>Subject: [edk2-devel] [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus
>cast
>
>The HandleProtocol() boot service takes an EFI_HANDLE, not an
>(EFI_HANDLE*). Remove the bogus cast in the
>InternalImageHandleToFvHandle() function.
>
>This is a semantic cleanup; there is no change in behavior.
>
>Cc: Liming Gao <liming.gao at intel.com>
>Cc: Michael D Kinney <michael.d.kinney at intel.com>
>Signed-off-by: Laszlo Ersek <lersek at redhat.com>
>---
>
>Notes:
>    lightly tested, most probably: it's practically impossible to build a
>    platform without consuming DxeServicesLib
>
> MdePkg/Library/DxeServicesLib/DxeServicesLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
>b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
>index c416b2dd8c65..0735b2f80400 100644
>--- a/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
>+++ b/MdePkg/Library/DxeServicesLib/DxeServicesLib.c
>@@ -49,7 +49,7 @@ InternalImageHandleToFvHandle (
>   ASSERT (ImageHandle != NULL);
>
>   Status = gBS->HandleProtocol (
>-             (EFI_HANDLE *) ImageHandle,
>+             ImageHandle,
>              &gEfiLoadedImageProtocolGuid,
>              (VOID **) &LoadedImage
>              );
>--
>2.19.1.3.g30247aa5d201
>
>
>
>-=-=-=-=-=-=
>Groups.io Links: You receive all messages sent to this group.
>
>View/Reply Online (#47404): https://edk2.groups.io/g/devel/message/47404
>Mute This Topic: https://groups.io/mt/34180218/1759384
>Group Owner: devel+owner at edk2.groups.io
>Unsubscribe: https://edk2.groups.io/g/devel/unsub  [liming.gao at intel.com]
>-=-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47453): https://edk2.groups.io/g/devel/message/47453
Mute This Topic: https://groups.io/mt/34180218/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-