[edk2-devel] [edk2-platforms][PATCH V1 12/12] Add GalagoPro3 board details to global build and documentation
Jeremy Soller
jeremy at system76.com
Mon Sep 23 22:38:24 UTC 2019
Reviewed-by: Jeremy Soller <jeremy at system76.com>
On Fri, Sep 20, 2019, at 12:40 PM, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
>
> * Updates maintainers for the System 76 GalagoPro3 board
> * Updated Readme.md with System 76 GalagoPro3 board details
> * Adds the ability to build the GalagoPro3 board to build.cfg
>
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Ankit Sinha <ankit.sinha at intel.com>
> Cc: Jeremy Soller <jeremy at system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki at intel.com>
> ---
> Maintainers.txt | 3 ++
> Platform/Intel/Readme.md | 44 +++++++++++++-------
> Platform/Intel/build.cfg | 1 +
> 3 files changed, 34 insertions(+), 14 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index a30ee2f602..1260c8d246 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -87,6 +87,9 @@ M: Chasel Chiu <chasel.chiu at intel.com>
> M: Michael Kubacki <michael.a.kubacki at intel.com>
> M: Nate DeSimone <nathaniel.l.desimone at intel.com>
>
> +Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3
> +R: Jeremy Soller <jeremy at system76.com>
> +
> Platform/Intel/MinPlatformPkg
> M: Michael Kubacki <michael.a.kubacki at intel.com>
> M: Chasel Chiu <chasel.chiu at intel.com>
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index 6a9b1d2e00..03fa4c2315 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -83,6 +83,15 @@ A UEFI firmware implementation using MinPlatformPkg
> is constructed using the fol
>
> ----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> | Simics Quick Start Package | Nehalem
> | SimicsOpenBoardPkg | BoardX58Ich10 |
>
> +#### System 76
> +
> +***Galago Pro Laptop***
> +
> +| Machine Name | Supported Chipsets
> | BoardPkg | Board Name |
> +----------------------------------------|--------------------------------------------|------------------------------|--------------------|
> +| galp2 | Kaby Lake
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +| galp3 & galp3-b | Kaby Lake Refresh
> | KabylakeOpenBoardPkg | GalagoPro3 |
> +
> ## Board Package Organization
> The board package follows the standard EDK II package structure with
> the following additional elements and guidelines:
> * Only code usable across more than one board at the root level.
> @@ -217,28 +226,31 @@ return back to the minimum platform caller.
> | | | post-build, and clean
> functions.
> | | |
> | | |------KabylakeOpenBoardPkg
> - | | | |------KabylakeRvp3
> - | | | |---build_config.cfg:
> KabylakeRvp3 specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build, build
> - | | | and
> clean post-build functions.
> + | | | |------GalagoPro3
> + | | | | |---build_config.cfg:
> System 76 Galago Pro 3 specific build
> + | | | |
> settings environment variables.
> + | | | |------KabylakeRvp3
> + | | | |---build_config.cfg:
> KabylakeRvp3 specific
> + | | | | build
> settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build, build
> + | | | and
> clean post-build functions.
> | | |
> | | |------PurleyOpenBoardPkg
> | | | |------BoardMtOlympus
> - | | | |---build_config.cfg:
> BoardMtOlympus specific
> - | | | |
> build settings, environment variables.
> - | | | |---build_board.py:
> Optional board-specific pre-build,
> - | | | build,
> post-build and clean functions.
> + | | | |---build_config.cfg:
> BoardMtOlympus specific
> + | | | | build
> settings, environment variables.
> + | | | |---build_board.py:
> Optional board-specific pre-build,
> + | | | build,
> post-build and clean functions.
> | | |
> | | |------SimicsOpenBoardPkg
> | | | |------BoardX58Ich10
> - | | | |---build_config.cfg:
> BoardX58Ich10 specific
> - | | | |
> build settings, environment variables.
> + | | | |---build_config.cfg:
> BoardX58Ich10 specific
> + | | | build
> settings, environment variables.
> | | |
> | | |------WhiskeylakeOpenBoardPkg
> - | | | |------WhiskeylakeURvp
> - | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> - | | |
> settings environment variables.
> + | | | |------WhiskeylakeURvp
> + | | | |---build_config.cfg:
> WhiskeylakeURvp specific build
> + | | |
> settings environment variables.
> | | |
> |------FSP
> </pre>
> @@ -263,6 +275,10 @@ errors.
> ### **Known limitations**
>
> **KabylakeOpenBoardPkg**
> +*GalagoPro3*
> +1. The firmware project has not been tested on the Galago Pro 3B.
> +
> +*KabylakeRvp3*
> 1. This firmware project has only been tested for Microsoft Windows 10
> x64 boot with AHCI mode and Integrated Graphic
> Device.
>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg
> index 04e8f4fa64..2040774d1b 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -54,5 +54,6 @@ NUMBER_OF_PROCESSORS = 0
> # board_name = path_to_board_build_config.cfg
> BoardMtOlympus = PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
> BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
> +GalagoPro3 = KabylakeOpenBoardPkg/GalagoPro3/build_config.cfg
> KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> WhiskeylakeURvp = WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> --
> 2.16.2.windows.1
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#47878): https://edk2.groups.io/g/devel/message/47878
Mute This Topic: https://groups.io/mt/34233779/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list