[edk2-devel] [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo

[Philippe Mathieu-Daudé]

On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) --
> objects to ConvertAndConnectControllers(), and
> ConvertAndConnectControllers() passes those to gBS->OpenProtocol().
> 
> Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE
> parameter types, not (EFI_HANDLE*) -- (VOID**) -- types.
> 
> This typo is masked because (VOID*) converts to and from any
> pointer-to-object type silently.
> 
> Note that functionally speaking there is no problem, so this patch does
> not change beavior, only cleans up the code.
> 
> Cc: Jaben Carsey <jaben.carsey at intel.com>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Zhichao Gao <zhichao.gao at intel.com>
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
> 
> Notes:
>     tested with "connect -r"
> 
>  ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
> index 359394dfd291..3f4e132674ea 100644
> --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
> +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c
> @@ -346,8 +346,8 @@ ShellConnectFromDevPaths (
>  **/
>  EFI_STATUS
>  ConvertAndConnectControllers (
> -  IN EFI_HANDLE     *Handle1 OPTIONAL,
> -  IN EFI_HANDLE     *Handle2 OPTIONAL,
> +  IN EFI_HANDLE     Handle1 OPTIONAL,
> +  IN EFI_HANDLE     Handle2 OPTIONAL,
>    IN CONST BOOLEAN  Recursive,
>    IN CONST BOOLEAN  Output
>    )
> 

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#47965): https://edk2.groups.io/g/devel/message/47965
Mute This Topic: https://groups.io/mt/34180231/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-