[edk2-devel] [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section
Liming Gao
liming.gao at intel.com
Wed Sep 25 00:43:23 UTC 2019
Laszlo:
>-----Original Message-----
>From: Laszlo Ersek [mailto:lersek at redhat.com]
>Sent: Wednesday, September 25, 2019 1:27 AM
>To: Gao, Liming <liming.gao at intel.com>; devel at edk2.groups.io
>Cc: Andrew Fish <afish at apple.com>; Leif Lindholm <leif.lindholm at linaro.org>;
>Kinney, Michael D <michael.d.kinney at intel.com>
>Subject: Re: [Patch] Maintainers.txt: Move ShellBin maintainers to EDK II
>Releases section
>
>Hi Liming,
>
>On 09/24/19 03:19, Liming Gao wrote:
>> ShellBinPkg is generated for each edk2 stable tag release.
>>
>> Cc: Andrew Fish <afish at apple.com>
>> Cc: Laszlo Ersek <lersek at redhat.com>
>> Cc: Leif Lindholm <leif.lindholm at linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney at intel.com>
>> Signed-off-by: Liming Gao <liming.gao at intel.com>
>> ---
>> Maintainers.txt | 13 ++++++-------
>> 1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index f348d70df3..f75b35d5a8 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -82,6 +82,12 @@ EDK II Releases:
>> W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-
>Planning
>> M: Liming Gao <liming.gao at intel.com>
>>
>> +W: https://github.com/tianocore/edk2/releases/download/edk2-
>stable20XXXX/ShellBinPkg.zip
>
>I'm not a fan of this link. It contains "XXXX", therefore it cannot work
>with a simple click (or copy & paste). And it's not easy to notice the
>"XXXX" part, and to substitute a valid stable tag identifier for it.
>
>All the links we provide should work without manual tweaking, in my
>opinion. They might not provide an immediately downloadable file (which
>is fine with me), but they should not result in a 404.
>
>How about the following:
>
>UEFI Shell Binaries (ShellBinPkg.zip) from EDK II Releases:
>-----------------------------------------------------------
>W: https://github.com/tianocore/edk2/releases/
>M: ...
>M: ...
>M: ...
>M: ...
>
Good suggestion. I will use this style.
Thanks
Liming
>This allows users to go to the releases page, and search that page for
>"ShellBinPkg.zip".
>
>For me, the "Assets" block of the latest release is open immediately,
>upon loading the page, and so searching the page for "ShellBinPkg.zip"
>provides a hit at once. If a user wants an older build, they can locate
>the Assets blocks under older releases, and look for "ShellBinPkg.zip"
>there.
>
>Thanks
>Laszlo
>
>> +M: Ray Ni <ray.ni at intel.com> (Ia32/X64)
>> +M: Zhichao Gao <zhichao.gao at intel.com> (Ia32/X64)
>> +M: Leif Lindholm <leif.lindholm at linaro.org> (ARM/AArch64)
>> +M: Ard Biesheuvel <ard.biesheuvel at linaro.org> (ARM/AArch64)
>> +
>> EDK II Architectures:
>> ---------------------
>> ARM, AARCH64
>> @@ -421,13 +427,6 @@ W:
>https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
>> M: Ray Ni <ray.ni at intel.com>
>> M: Zhichao Gao <zhichao.gao at intel.com>
>>
>> -Maintainers for stable Shell binaries generation
>> -when need to publish Shell binaries with edk2 release:
>> -M: Ray Ni <ray.ni at intel.com> (Ia32/X64)
>> -M: Zhichao Gao <zhichao.gao at intel.com> (Ia32/X64)
>> -M: Leif Lindholm <leif.lindholm at linaro.org> (ARM/AArch64)
>> -M: Ard Biesheuvel <ard.biesheuvel at linaro.org> (ARM/AArch64)
>> -
>> SignedCapsulePkg
>> F: SignedCapsulePkg/
>> W:
>https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48001): https://edk2.groups.io/g/devel/message/48001
Mute This Topic: https://groups.io/mt/34271643/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list