[edk2-devel] [edk2-platforms][PATCH V2 04/15] KabylakeOpenBoardPkg: Move policy update libs to KabylakeRvp3 board

Chiu, Chasel chasel.chiu at intel.com
Wed Sep 25 09:50:43 UTC 2019 

Reviewed-by: Chasel Chiu <chasel.chiu at intel.com>


> -----Original Message-----
> From: Kubacki, Michael A <michael.a.kubacki at intel.com>
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel at edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone at intel.com>; Sinha, Ankit <ankit.sinha at intel.com>;
> Jeremy Soller <jeremy at system76.com>
> Subject: [edk2-platforms][PATCH V2 04/15] KabylakeOpenBoardPkg: Move
> policy update libs to KabylakeRvp3 board
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207
> 
> To prepare KabylakeOpenBoardPkg for multi-board support, the policy
> update libraries should be moved to the individual board directory.
> Prevously KabylakeOpenBoardPkg only supported the KabylakeRvp3 board
> and the policy update libraries were kept above the board directory level.
> 
> Cc: Chasel Chiu <chasel.chiu at intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone at intel.com>
> Cc: Ankit Sinha <ankit.sinha at intel.com>
> Cc: Jeremy Soller <jeremy at system76.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki at intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> | 6 +++---
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconP
> olicyUpdateLibFsp.inf | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpd
> ateLib.inf           | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpda
> teLib.inf           | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolic
> yUpdate.h             | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicy
> Update.h              | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h
> | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h
> | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PcieDevice
> Table.c                | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspMisc
> UpdUpdateLib.c         | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspPolic
> yUpdateLib.c          | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolic
> yUpdate.c             | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolic
> yUpdatePreMem.c       | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicy
> Update.c              | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicy
> UpdatePreMem.c        | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c
> | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.
> c                     | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpd
> ateLib.c             | 0
>  Platform/Intel/KabylakeOpenBoardPkg/{ =>
> KabylakeRvp3}/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpda
> teLib.c             | 0
>  19 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> index 813ca040a1..7090852192 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
> @@ -127,13 +127,13 @@
>    #
>    # Below library are used by FSP API mode
>    #
> -
> SiliconPolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> +
> + SiliconPolicyUpdateLib|$(PROJECT)/FspWrapper/Library/PeiSiliconPolicyU
> + pdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> 
> SiliconPolicyInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconPolicyInitLib
> Fsp/PeiSiliconPolicyInitLibFsp.inf
>  !else
>    #
>    # Below library are used by FSP Dispatch mode and non-FSP build (EDK2
> build)
>    #
> -
> SiliconPolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/PeiSili
> conPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
> +
> + SiliconPolicyUpdateLib|$(PROJECT)/Policy/Library/PeiSiliconPolicyUpdat
> + eLib/PeiSiliconPolicyUpdateLib.inf
> 
> SiliconPolicyInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconPolicyInitLib
> Fsp/PeiSiliconPolicyInitLibFspAml.inf
>  !endif
> 
> @@ -196,7 +196,7 @@
> 
> BoardAcpiTableLib|$(PLATFORM_PACKAGE)/Acpi/Library/MultiBoardAcpiSup
> portLib/DxeMultiBoardAcpiSupportLib.inf
> 
> 
> SiliconPolicyInitLib|$(PLATFORM_SI_PACKAGE)/Library/DxeSiliconPolicyInitLib
> /DxeSiliconPolicyInitLib.inf
> -
> SiliconPolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
> +
> + SiliconPolicyUpdateLib|$(PROJECT)/Policy/Library/DxeSiliconPolicyUpdat
> + eLib/DxeSiliconPolicyUpdateLib.inf
> 
>  #
>  # Silicon Init Package
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeSiliconPolicyUpdateLib.inf
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeSiliconPolicyUpdateLib.inf
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/PeiSiliconPolicyUpda
> teLib/PeiSiliconPolicyUpdateLib.inf
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSili
> conPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/PeiSiliconPolicyUpdate
> Lib/PeiSiliconPolicyUpdateLib.inf
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilico
> nPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiPchPolicyUpdate.h
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiPchPolicyUpdate.h
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiSaPolicyUpdate.h
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiSaPolicyUpdate.h
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeGopPolicyInit.h
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeGopPolicyInit.h
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeGopPolicyInit.h
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeGopPolicyInit.h
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeSaPolicyInit.h
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeSaPolicyInit.h
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeSaPolicyInit.h
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeSaPolicyInit.h
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PcieDeviceTable.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PcieDeviceTable.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiFspMiscUpdUpdateLib.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiFspPolicyUpdateLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiFspPolicyUpdateLib.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiPchPolicyUpdate.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiPchPolicyUpdate.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiPchPolicyUpdatePreMem.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiSaPolicyUpdate.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiSaPolicyUpdate.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolic
> yUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/
> PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU
> pdateLibFsp/PeiSaPolicyUpdatePreMem.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/P
> eiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeGopPolicyInit.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeGopPolicyInit.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeGopPolicyInit.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeGopPolicyInit.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeSaPolicyUpdate.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeSaPolicyUpdate.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeSaPolicyUpdate.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeSaPolicyUpdate.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpd
> ateLib/DxeSiliconPolicyUpdateLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSil
> iconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/DxeSiliconPolicyUpdate
> Lib/DxeSiliconPolicyUpdateLib.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/DxeSilic
> onPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/PeiSiliconPolicyUpda
> teLib/PeiSiliconPolicyUpdateLib.c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSili
> conPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c
> similarity index 100%
> rename from
> Platform/Intel/KabylakeOpenBoardPkg/Policy/Library/PeiSiliconPolicyUpdate
> Lib/PeiSiliconPolicyUpdateLib.c
> rename to
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilico
> nPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48020): https://edk2.groups.io/g/devel/message/48020
Mute This Topic: https://groups.io/mt/34279344/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

More information about the edk2-devel-archive mailing list