[edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security Command Protocol
Wu, Hao A
hao.a.wu at intel.com
Sun Sep 29 07:30:51 UTC 2019
> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, September 27, 2019 10:20 AM
> To: devel at edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A
> Subject: [edk2-devel] [PATCH v8 0/4] Add SCSI Support for Storage Security
> Command Protocol
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1546
>
> V8 changes:
> Align Inc512 definition in UefiScsiLib.h with that in UefiScsiLib.c.
>
> V7 changes:
> Changed Inc512 behavior to always take DataLength as bytes, and divide
> by 512 only in the CDB.
>
> V6 changes:
> Restore EFI_SCSI_TYPE defines for ASC IT8 devices. Revert EFI_SCSI_IO_TYPE
> changes in Protocol\ScsiIo.h. Add INC_512 parameter for SecurityProtocol
> In/Out commands in UefiScsiLib. Change UINT32 args to UINTN to match the
> definitions for Storage Security Command Protocol.
>
> V5 changes:
> Split MdeModulePkg changes into separate patches. Add ReinstallProtocol
> calls for StorageSecurityCommand Protocol. Restore original MediaPresent
> and ReadCapacity behavior, with new implementation for WLUN type media.
> Clear temporary aligned buffers before freeing them.
>
> V4 changes:
> Add SSC Protocol in addition to BlockIo instead of in place of BlockIo.
> Add error handling for (BlockSize == 0) in Read and WriteBlocks commands
> to handle partitions that do not support ReadCapacity().
>
> V3 changes:
> Initialize AlignedBuffer variable in ScsiDiskReceiveData and
> ScsiDiskSendData functions. Remove redundant input validation and debug
> message in ScsiDiskSendData.
>
> V2 changes:
> Split the patch into separate commits for separate packages.
>
> To support RPMB access on UFS devices, support must be added to
> the ScsiDiskDxe driver for the Storage Security Command Protocol.
>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Jian J Wang <jian.j.wang at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> Cc: Hao A Wu <hao.a.wu at intel.com>
>
> Christopher J Zurcher (4):
> MdePkg: Implement SCSI commands for Security Protocol In/Out
For patch 1,
Reviewed-by: Hao A Wu <hao.a.wu at intel.com>
Hello Liming,
Do you have additional comment on the patch?
> MdeModulePkg/UfsPassThruDxe: Check for RPMB W-LUN (SecurityLun)
> MdeModulePkg/ScsiBusDxe: Clean up Peripheral Type check
> MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol
Since the MdeModulePkg part is the same with V6 series, thus:
Reviewed-by: Hao A Wu <hao.a.wu at intel.com>
Best Regards,
Hao Wu
>
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf | 3 +-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.h | 171 +++++-
> MdePkg/Include/IndustryStandard/Scsi.h | 48 +-
> MdePkg/Include/Library/UefiScsiLib.h | 130 ++++-
> MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 5 +-
> MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 616
> +++++++++++++++++++-
> MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 17 +-
> MdePkg/Library/UefiScsiLib/UefiScsiLib.c | 229 +++++++-
> 8 files changed, 1181 insertions(+), 38 deletions(-)
>
> --
> 2.16.2.windows.1
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48265): https://edk2.groups.io/g/devel/message/48265
Mute This Topic: https://groups.io/mt/34306978/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list