[edk2-devel] [PATCH v2 08/28] Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib

[Leif Lindholm]

On Fri, Mar 20, 2020 at 20:05:23 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal at nxp.com>
> 
> UART Programming model in LS1043A is compatible with PC16550D.
> Therefore, BaseSerialPortLib16550 can be used instead of our own
> implementation of SerialPortLib.
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal at nxp.com>

Reviewed-by: Leif Lindholm <leif at nuviainc.com>
(If the need for SerialUartClockLib goes away, that line can be
dropped without re-review being required.)

> ---
>  Platform/NXP/NxpQoriqLs.dsc.inc     | 3 +++
>  Silicon/NXP/LS1043A/LS1043A.dsc.inc | 5 ++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/NXP/NxpQoriqLs.dsc.inc b/Platform/NXP/NxpQoriqLs.dsc.inc
> index 94d3e53a046b..234a5e2707cd 100644
> --- a/Platform/NXP/NxpQoriqLs.dsc.inc
> +++ b/Platform/NXP/NxpQoriqLs.dsc.inc
> @@ -98,6 +98,9 @@ [LibraryClasses.common]
>    ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    IoAccessLib|Silicon/NXP/Library/IoAccessLib/IoAccessLib.inf
>  
> +  PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf
> +  PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
> +
>  [LibraryClasses.common.SEC]
>    PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>    UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> diff --git a/Silicon/NXP/LS1043A/LS1043A.dsc.inc b/Silicon/NXP/LS1043A/LS1043A.dsc.inc
> index d2d4133428c3..f6f15a482a85 100644
> --- a/Silicon/NXP/LS1043A/LS1043A.dsc.inc
> +++ b/Silicon/NXP/LS1043A/LS1043A.dsc.inc
> @@ -8,8 +8,10 @@
>  #
>  
>  [LibraryClasses.common]
> +  PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf
>    SocLib|Silicon/NXP/Library/SocLib/LS1043aSocLib.inf
> -  SerialPortLib|Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf
> +  SerialUartClockLib|Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
> +  SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf
>  
>  ################################################################################
>  #
> @@ -25,6 +27,7 @@ [PcdsDynamicDefault.common]
>  
>  [PcdsFixedAtBuild.common]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase|0x021c0500
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio|TRUE
>  
>    #
>    # CCSR Address Space and other attached Memories
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56831): https://edk2.groups.io/g/devel/message/56831
Mute This Topic: https://groups.io/mt/72077433/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-