[edk2-devel] [PATCH v2 24/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit

[Leif Lindholm]

On Fri, Mar 20, 2020 at 20:05:39 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal <pankaj.bansal at nxp.com>
> 
> SocInit can be defined in SocLib.h
> No need to make it extern in ArmPlatformLib
> 
> Signed-off-by: Pankaj Bansal <pankaj.bansal at nxp.com>

Reviewed-by: Leif Lindholm <leif at nuviainc.com>

But do please move it as early as possible in the series.

> ---
>  .../LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 --
>  Silicon/NXP/Include/Library/SocLib.h                      | 8 ++++++++
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
> index 1e2e85f87dfe..dc81e7ba3101 100644
> --- a/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
> +++ b/Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c
> @@ -16,8 +16,6 @@
>  #include <Ppi/ArmMpCoreInfo.h>
>  #include <Ppi/NxpPlatformGetClock.h>
>  
> -extern VOID SocInit (VOID);
> -
>  /**
>    Get the clocks supplied by Platform(Board) to NXP Layerscape SOC IPs
>  
> diff --git a/Silicon/NXP/Include/Library/SocLib.h b/Silicon/NXP/Include/Library/SocLib.h
> index 749aa230dec5..0ca68602618d 100644
> --- a/Silicon/NXP/Include/Library/SocLib.h
> +++ b/Silicon/NXP/Include/Library/SocLib.h
> @@ -41,4 +41,12 @@ SocGetClock (
>    IN  VA_LIST       Args
>    );
>  
> +/**
> +  Function to initialize SoC specific constructs
> + **/
> +VOID
> +SocInit (
> +  VOID
> +  );
> +
>  #endif // SOC_LIB_H__
> -- 
> 2.17.1
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56863): https://edk2.groups.io/g/devel/message/56863
Mute This Topic: https://groups.io/mt/72077456/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-