[edk2-devel] [PATCH 1/5] ArmPkg/CpuDxe: use private copy of GetRootTranslationTableInfo()

[Ard Biesheuvel]

On 4/2/20 1:03 PM, Leif Lindholm wrote:
> On Thu, Apr 02, 2020 at 12:29:30 +0200, Ard Biesheuvel wrote:
>> On 4/2/20 12:28 PM, Leif Lindholm wrote:
>>> On Thu, Apr 02, 2020 at 12:20:54 +0200, Ard Biesheuvel wrote:
>>>> On 4/2/20 12:16 PM, Leif Lindholm via groups.io wrote:
>>>>> On Sat, Mar 28, 2020 at 11:43:17 +0100, Ard Biesheuvel wrote:
>>>>>> Before getting rid of GetRootTranslationTableInfo() and the related
>>>>>> LookupAddresstoRootTable() in AARCH64's version of ArmMmuLib, add a
>>>>>> version of the former to CpuDxe, which will be its only remaining
>>>>>> user. While at it, simplify it a bit, since in the CpuDxe cases,
>>>>>> both OUT arguments are always provided.
> 
> Summary after discussing off-list:
> This patch isn't *just* moving a public function private, but it's
> replacing use of a function that was never meant to be public and had
> a completely bonkers forward-declaration in a different module.
> 
> Ard has agreed to make the commit message more explicit on that point,
> and I'm happy with that. So with that change, for the series:
> Reviewed-by: Leif Lindholm <leif at nuviainc.com>
> 

Pushed, thanks.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56902): https://edk2.groups.io/g/devel/message/56902
Mute This Topic: https://groups.io/mt/72606847/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-