[edk2-devel] [PATCH 1/1] ArmVirtPkg: Include NVMe support in ArmVirtQemu*

[Ard Biesheuvel]

On 4/9/20 4:31 PM, Leif Lindholm wrote:
> On Thu, Apr 09, 2020 at 15:07:30 +0200, Ard Biesheuvel wrote:
>> On 4/9/20 2:10 PM, Leif Lindholm wrote:
>>> From: Leendert van Doorn <leendert at microsoft.com>
>>>
>>> Enable conditional support for NVMe storage in ArmVirtQemu/
>>> QemVirtQemuKernel in order to simplify booting/installing operating
>>> systems that don't support virtio.
>>>
>>> [Conditionalised driver inclusion]
>>
>> Why?
> 
> Well, it adds size and complexity for a target most frequently used to
> model a pure virtual environment?
> 
> Size difference isn't huge though:
> FVMAIN [99%Full] 5337920 total, 5337864 used, 56 free
> FVMAIN_COMPACT [39%Full] 2093056 total, 829392 used, 1263664 free
> vs.
> FVMAIN [99%Full] 5300992 total, 5300936 used, 56 free
> FVMAIN_COMPACT [38%Full] 2093056 total, 804128 used, 1288928 free
> 
> If that's not an issue, I'm happy to drop it and my bracketing.
> 

I agree that in general, driver stacks like network or TPM should be 
opt-in, but given the reason you are adding this [compatibility with 
other OSes], I'd prefer to have this one always built in.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57128): https://edk2.groups.io/g/devel/message/57128
Mute This Topic: https://groups.io/mt/72894709/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-