[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

[Kun Qin via groups.io]

Hi Guomin,

Could you please point me to the proposed change?

Thanks,
Kun

From: Jiang, Guomin <guomin.jiang at intel.com>
Sent: Wednesday, April 8, 2020 6:30 PM
To: Sean Brogan <sean.brogan at microsoft.com>; devel at edk2.groups.io
Cc: Kun Qin <Kun.Qin at microsoft.com>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Sean,

I think it meet the original code logic more closely.

According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer.

I have reviewed the suggested change and think both are the same logic.

Hi Qin,

Can you give some comment?

Best Regards
guomin
From: sean.brogan via [] <sean.brogan=microsoft.com@[]<mailto:sean.brogan=microsoft.com@[]>>
Sent: Wednesday, April 8, 2020 2:00 PM
To: Jiang, Guomin <guomin.jiang at intel.com<mailto:guomin.jiang at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Guomin,

Can you speak to why you implemented differently than the suggested and validated patch?  Seems you created a local whereas ours just used the internal data member.

Thanks
sean

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57293): https://edk2.groups.io/g/devel/message/57293
Mute This Topic: https://groups.io/mt/72671870/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200410/78937559/attachment.htm>