[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

[Kun Qin via groups.io]

Hi Guomin,

Thanks for point the commit below to me. I agree that the change is functionally the same, and I am also with Sean that the local variable seems redundant. But is there other reason we used this local variable in the first place? I thought the first implementation<https://github.com/microsoft/mu_basecore/blob/608b28d6e2b977dfb05d806bf4d1c4fd12c87462/MsUnitTestPkg/Library/UnitTestLib/UnitTestLib.c#L263> did not have it.

Thanks,
Kun

From: Jiang, Guomin <guomin.jiang at intel.com>
Sent: Sunday, April 12, 2020 11:21 PM
To: Kun Qin <Kun.Qin at microsoft.com>; Sean Brogan <sean.brogan at microsoft.com>; devel at edk2.groups.io
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Qin,

Refer https://github.com/guominjia/edk2/commit/eed5154853f6522e6150b9cff16d24e0c88ad3cc<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fguominjia%2Fedk2%2Fcommit%2Feed5154853f6522e6150b9cff16d24e0c88ad3cc&data=02%7C01%7CKun.Qin%40microsoft.com%7C65d030006a89412c383c08d7df72d1a1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637223556552433909&sdata=%2BVqQE4pRZt6nueZrfqywcsyd6D2zlDYDbOjfHgZTPGE%3D&reserved=0>

Best Regards
guomin

From: Kun Qin <Kun.Qin at microsoft.com<mailto:Kun.Qin at microsoft.com>>
Sent: Friday, April 10, 2020 3:18 PM
To: Jiang, Guomin <guomin.jiang at intel.com<mailto:guomin.jiang at intel.com>>; Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Guomin,

Could you please point me to the proposed change?

Thanks,
Kun

From: Jiang, Guomin <guomin.jiang at intel.com<mailto:guomin.jiang at intel.com>>
Sent: Wednesday, April 8, 2020 6:30 PM
To: Sean Brogan <sean.brogan at microsoft.com<mailto:sean.brogan at microsoft.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Cc: Kun Qin <Kun.Qin at microsoft.com<mailto:Kun.Qin at microsoft.com>>
Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Hi Sean,

I think it meet the original code logic more closely.

According to the LoadUnitTestCache(), it need pointer to pointer, the defect is resulted by pointer to local pointer and I think the original logical just want use the local variable as pointer to pointer.

I have reviewed the suggested change and think both are the same logic.

Hi Qin,

Can you give some comment?

Best Regards
guomin
From: sean.brogan via [] <sean.brogan=microsoft.com@[]<mailto:sean.brogan=microsoft.com@[]>>
Sent: Wednesday, April 8, 2020 2:00 PM
To: Jiang, Guomin <guomin.jiang at intel.com<mailto:guomin.jiang at intel.com>>; devel at edk2.groups.io<mailto:devel at edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Correct dereferred pointer.

Guomin,

Can you speak to why you implemented differently than the suggested and validated patch?  Seems you created a local whereas ours just used the internal data member.

Thanks
sean

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57294): https://edk2.groups.io/g/devel/message/57294
Mute This Topic: https://groups.io/mt/72671870/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200413/953ce7e6/attachment.htm>