[edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

Sean via groups.io sean.brogan=microsoft.com at groups.io
Wed Apr 15 20:38:03 UTC 2020


On Wed, Apr 15, 2020 at 10:18 AM, Laszlo Ersek wrote:

> 
> ArmVirtPkg/ArmVirtPkg.ci.yaml
> ArmVirtPkg/PlatformCI/Ubuntu-GCC5.yml
> ArmVirtPkg/PlatformCI/PlatformBuild.py
> ArmVirtPkg/PlatformCI/README-pytools.md
> ArmVirtPkg/PlatformCI/iasl_ext_dep.yaml

I am ok with the above except one thought on the readme.  One nice thing about the markdown readme files are the badge shows up in github when you view the package.  This is a quick and easy way to see the current status.

* Ovmf has a pretty stale readme and does not take advantage of markdown.    We could convert it to MD, clean up, and then merge in the content from the pytools.md.  I would need help or a package maintainer to do the cleanup of the readme to make sure it contained the content you desired.
* ArmVirtPkg doesn't have a readme and this is definitely a barrier to entry for the package.  I would suggest creating one and then merging in the content from the pytools.md.
* EmulatorPkg has one.  I would just suggest a merge but i am yet to get any feedback from those maintainers.

If that isn't desirable i would at least suggest we change the title to just ReadMe.md so that GitHub shows it by default when the PaltformCI folder is viewed form the web or in editor like vscode.

Thanks
Sean

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#57432): https://edk2.groups.io/g/devel/message/57432
Mute This Topic: https://groups.io/mt/72880537/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200415/ddac4c46/attachment.htm>


More information about the edk2-devel-archive mailing list