[edk2-devel] [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete

[Laszlo Ersek]

On 04/29/20 18:36, Leif Lindholm wrote:
> A bunch of legacy drivers (most not compliant with UEFI driver model)
> added for various ARM development platforms are still in EmbeddedPkg,
> which was arguably the only possible location for them before
> edk2-platforms was added.
> 
> DwEmmcDxe, Isp1761UsbDxe, Lan9118Dxe, and Lan91xDxe all use a
> Pcd*BaseAddress mechanism making them *fundamentally* incompatible
> with the UEFI driver model, and preventing use of more than one device
> instance per system.
> 
> SataSiI3132Dxe *looks* like a proper UEFI driver, but would need
> re-review with that in mind for moving to edk2-platforms.
> 
> Mark these as Status: Obsolete in Maintainers.txt to at the very least
> indicate that they are not suitable references.
> 
> Cc: Andrew Fish <afish at apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
> Cc: Laszlo Ersek <lersek at redhat.com>
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Signed-off-by: Leif Lindholm <leif at nuviainc.com>
> ---
>  Maintainers.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 4d62e0b334f3..3415a0410b7b 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -172,6 +172,11 @@ M: Alexei Fedorov <Alexei.Fedorov at arm.com>
>  
>  EmbeddedPkg
>  F: EmbeddedPkg/
> +X: EmbeddedPkg/Drivers/DwEmmcDxe/
> +X: EmbeddedPkg/Drivers/Isp1761UsbDxe/
> +X: EmbeddedPkg/Drivers/Lan9118Dxe/
> +X: EmbeddedPkg/Drivers/Lan91xDxe/
> +X: EmbeddedPkg/Drivers/SataSiI3132Dxe/
>  X: EmbeddedPkg/Include/Protocol/MmcHost.h
>  X: EmbeddedPkg/Universal/MmcDxe/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
> @@ -179,6 +184,11 @@ M: Leif Lindholm <leif at nuviainc.com>
>  M: Ard Biesheuvel <ard.biesheuvel at arm.com>
>  
>  EmbeddedPkg obsolete code
> +F: EmbeddedPkg/Drivers/DwEmmcDxe/
> +F: EmbeddedPkg/Drivers/Isp1761UsbDxe/
> +F: EmbeddedPkg/Drivers/Lan9118Dxe/
> +F: EmbeddedPkg/Drivers/Lan91xDxe/
> +F: EmbeddedPkg/Drivers/SataSiI3132Dxe/
>  F: EmbeddedPkg/Include/Protocol/MmcHost.h
>  F: EmbeddedPkg/Universal/MmcDxe/
>  S: Obsolete
> 

same generic observations as under patch#2

Reviewed-by: Laszlo Ersek <lersek at redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58334): https://edk2.groups.io/g/devel/message/58334
Mute This Topic: https://groups.io/mt/73356720/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-