[edk2-devel] acpiview error handling patches

[Sami Mujawar]

Hi Zhichao,

Thanks.  I have logged this in Bugzilla "Bug 2893 - Acpiview: Standardise error log output format" (https://bugzilla.tianocore.org/show_bug.cgi?id=2893).

Regards,

Sami Mujawar

-----Original Message-----
From: Gao, Zhichao <zhichao.gao at intel.com> 
Sent: 12 August 2020 01:41 AM
To: Sami Mujawar <Sami.Mujawar at arm.com>; devel at edk2.groups.io
Cc: tomas at nuviainc.com; Matteo Carlini <Matteo.Carlini at arm.com>
Subject: RE: [edk2-devel] acpiview error handling patches

I am fine with that. BTW, it is better to add a BZ for this change. BZ would make a good history of the discussion on this feature or bug fix.
Consumers may not aware of the discussion thru devel at edk2.groups.io, but they will always find the record in BZ link.

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <Sami.Mujawar at arm.com>
> Sent: Tuesday, August 11, 2020 9:45 PM
> To: devel at edk2.groups.io; Gao, Zhichao <zhichao.gao at intel.com>
> Cc: tomas at nuviainc.com; Matteo Carlini <Matteo.Carlini at arm.com>
> Subject: RE: [edk2-devel] acpiview error handling patches
> 
> Hi Zhichao,
> 
> Some patches in this series need reworking.
> 
> Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration 
> struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error counters'
> I feel accessor methods offer a better design and should be retained.
> 
> Other patches in the series need a bit of rework to follow coding conventions etc.
> 
> This patch series has too many changes to the parsers. I request to 
> put this patch series on hold as we have other patches that need to go in on priority. e.g.
> loop detection in PPTT table.
> 
> Since Tomas is no longer with Arm, someone from Arm will pick up 
> repost the reworked series.
> 
> Regards,
> 
> Sami Mujawar
> 
> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Gao, 
> Zhichao via groups.io
> Sent: 31 July 2020 01:43 AM
> To: devel at edk2.groups.io; tomas at nuviainc.com
> Subject: Re: [edk2-devel] acpiview error handling patches
> 
> I am  busy at other works recent weeks. I plan to review the patch in 
> next two weeks. Hope it is acceptable for you.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Tomas 
> > Pilar
> > (tpilar)
> > Sent: Wednesday, July 29, 2020 7:23 PM
> > To: Gao; Gao, Zhichao <zhichao.gao at intel.com>; devel at edk2.groups.io
> > Subject: Re: [edk2-devel] acpiview error handling patches
> >
> > (change of email)
> >
> > Hi Zhichao,
> >
> > I've amended the patches and respun a v3 version. Any chance you 
> > could have a look to see if I've fixed the issues correctly?
> >
> > Cheers,
> > Tom
> >
> >
> 
> 
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are 
> confidential and may also be privileged. If you are not the intended 
> recipient, please notify the sender immediately and do not disclose 
> the contents to any other person, use it for any purpose, or store or 
> copy the information in any medium. Thank you.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64113): https://edk2.groups.io/g/devel/message/64113
Mute This Topic: https://groups.io/mt/75329821/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-