[EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement
Bret Barkelew via groups.io
bret.barkelew=microsoft.com at groups.io
Tue Aug 25 19:40:05 UTC 2020
Had a chance to review the general design (not a deep code review, so no reviewed-by).
I think this works for us. Thanks for working on it!
- Bret
________________________________
From: devel at edk2.groups.io <devel at edk2.groups.io> on behalf of Bret Barkelew via groups.io <bret.barkelew=microsoft.com at groups.io>
Sent: Thursday, August 20, 2020 11:18 PM
To: Yao, Jiewen <jiewen.yao at intel.com>; devel at edk2.groups.io <devel at edk2.groups.io>; Zhang, Qi1 <qi1.zhang at intel.com>
Cc: Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement
Awesome. That gives me a little time. Thanks, Jiewen! And thanks for tracking the issue.
- Bret
From: Yao, Jiewen<mailto:jiewen.yao at intel.com>
Sent: Thursday, August 20, 2020 11:16 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Bret Barkelew<mailto:Bret.Barkelew at microsoft.com>; Zhang, Qi1<mailto:qi1.zhang at intel.com>
Cc: Wang, Jian J<mailto:jian.j.wang at intel.com>; Wu, Hao A<mailto:hao.a.wu at intel.com>; Chiu, Chasel<mailto:chasel.chiu at intel.com>; Desimone, Nathaniel L<mailto:nathaniel.l.desimone at intel.com>; Zeng, Star<mailto:star.zeng at intel.com>
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement
We are in SFF.
I posted to https://github.com/jyao1/edk2/tree/FspManifestNew<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjyao1%2Fedk2%2Ftree%2FFspManifestNew&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C0f6d7d98391f4fb503bc08d8459a0b15%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637335875209044797&sdata=NpmohCK2WW%2FuwfuCR1YOOlCrCH4KPTZzjOok60%2F32Q0%3D&reserved=0> temporarily.
Please let us know if you have any feedback.
I plan to post after the 202008 stable tag.
Thank you
Yao Jiewen
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Bret Barkelew via groups.io
Sent: Friday, August 21, 2020 1:56 PM
To: devel at edk2.groups.io; Zhang, Qi1 <qi1.zhang at intel.com>
Cc: Yao, Jiewen <jiewen.yao at intel.com>; Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>; Chiu, Chasel <chasel.chiu at intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com>; Zeng, Star <star.zeng at intel.com>
Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement
Does this live in a branch somewhere? I'd like to take a look at it and make sure it fully replaces our current custom solution.
Thanks!
- Bret
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> on behalf of Qi Zhang via groups.io <qi1.zhang=intel.com at groups.io<mailto:qi1.zhang=intel.com at groups.io>>
Sent: Monday, August 17, 2020 11:26 PM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>>
Cc: Qi Zhang <qi1.zhang at intel.com<mailto:qi1.zhang at intel.com>>; Yao, Jiewen <jiewen.yao at intel.com<mailto:jiewen.yao at intel.com>>; Jian J Wang <jian.j.wang at intel.com<mailto:jian.j.wang at intel.com>>; Hao A Wu <hao.a.wu at intel.com<mailto:hao.a.wu at intel.com>>; Chasel Chiu <chasel.chiu at intel.com<mailto:chasel.chiu at intel.com>>; Desimone, Nathaniel L <nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>>; Star Zeng <star.zeng at intel.com<mailto:star.zeng at intel.com>>
Subject: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement
v4 change:
rename FvEventLogRecordLib to TcgEventLogRecordLib.
v3 change:
add a new lib FvEventLogRecordLib for gerneric code.
REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2376&data=02%7C01%7CBret.Barkelew%40microsoft.com%7C0a458f4d4eea4c503fe908d8433fa25d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333287874367194&sdata=SGpI04kc3Tcoo36CQ903bnTN2NFPUxoc8YzIwzIdfcs%3D&reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2376&data=02%7C01%7Cbret.barkelew%40microsoft.com%7C0f6d7d98391f4fb503bc08d8459a0b15%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637335875209044797&sdata=tejYdFi8zWLVlwV6Zsg0aRotxAu4B%2FpHYdGmdETJF%2Fg%3D&reserved=0>
The EDKII BIOS calls FSP API in FSP Wrapper Pkg.
This FSP code need to be measured into TPM.
We need add a generic module in FSP Wrapper Pkg code to measure:
1) FSP-T, FSP-M, FSP-S in API mode.
2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported
as standard FV and they will be measured by TCG-PEI.
Cc: Jiewen Yao <jiewen.yao at intel.com<mailto:jiewen.yao at intel.com>>
Cc: Jian J Wang <jian.j.wang at intel.com<mailto:jian.j.wang at intel.com>>
Cc: Hao A Wu <hao.a.wu at intel.com<mailto:hao.a.wu at intel.com>>
Cc: Chasel Chiu <chasel.chiu at intel.com<mailto:chasel.chiu at intel.com>>
Cc: Nate DeSimone <nathaniel.l.desimone at intel.com<mailto:nathaniel.l.desimone at intel.com>>
Cc: Star Zeng <star.zeng at intel.com<mailto:star.zeng at intel.com>>
Cc: Qi Zhang <qi1.zhang at intel.com<mailto:qi1.zhang at intel.com>>
Jiewen Yao (4):
IntelFsp2WrapperPkg/FspMeasurementLib: Add header file.
IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib.
IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement.
IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and
PcdFspMeasurementConfig.
Qi Zhang (4):
SecurityPkg/TcgEventLogRecordLib: add new lib for firmware measurement
SecurityPkg/dsc: add FvEventLogRecordLib
SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY
IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib
.../FspmWrapperPeim/FspmWrapperPeim.c | 90 ++++++-
.../FspmWrapperPeim/FspmWrapperPeim.inf | 20 +-
.../FspsWrapperPeim/FspsWrapperPeim.c | 86 +++++-
.../FspsWrapperPeim/FspsWrapperPeim.inf | 27 +-
.../Include/Library/FspMeasurementLib.h | 39 +++
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 ++
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 10 +-
.../BaseFspMeasurementLib.inf | 54 ++++
.../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++
.../Include/Library/TcgEventLogRecordLib.h | 97 +++++++
SecurityPkg/Include/Ppi/Tcg.h | 5 +
.../TcgEventLogRecordLib.c | 197 ++++++++++++++
.../TcgEventLogRecordLib.inf | 40 +++
.../TcgEventLogRecordLib.uni | 17 ++
SecurityPkg/SecurityPkg.dec | 3 +
SecurityPkg/SecurityPkg.dsc | 2 +
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 12 +-
17 files changed, 939 insertions(+), 25 deletions(-)
create mode 100644 IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h
create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLib.inf
create mode 100644 IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c
create mode 100644 SecurityPkg/Include/Library/TcgEventLogRecordLib.h
create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.c
create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.inf
create mode 100644 SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLogRecordLib.uni
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#64624): https://edk2.groups.io/g/devel/message/64624
Mute This Topic: https://groups.io/mt/76414348/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200825/48298b7c/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 56ADC1A9D11749E9A5EE1B2C809D1077.png
Type: image/png
Size: 146 bytes
Desc: 56ADC1A9D11749E9A5EE1B2C809D1077.png
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200825/48298b7c/attachment.png>
More information about the edk2-devel-archive
mailing list