[edk2-devel] [PATCH v4 10/10] ArmPkg: Add Universal/Smbios, a generic SMBIOS library for ARM

[Rebecca Cran]

On 12/16/20 8:13 AM, Sami Mujawar wrote:

> Sorry for pushing for the function documentation. We are in process of enabling EKDII Core CI support for ArmPlatformPkg and ArmPkg.
> The ECC tool (checks for coding style and general good programming practices) is run as part of the Core CI. There are numerous issues reported by ECC tool and we are working towards fixing them before the Core CI is enabled.
> 
> Can you run the ECC tool for this patch and fix the reported issues, please?
> The following command can be used to run ECC on the ArmPkg\Universal\Smbios  folder.
>> python BaseTools\Source\Python\Ecc\EccMain.py  -c W:\edk2-review\edk2\BaseTools\Source\Python\Ecc\config.ini -e W:\edk2-review\edk2\BaseTools\Source\Python\Ecc\exception.xml -r W:\edk2-exports\edk2\Ecc.csv -t W:\edk2-review\edk2\ArmPkg\Universal\Smbios
> 
> The ECC errors 10002, 10006 and 10022 can be ignored for now (I don't know if these errors are real problems or false positives).

Given that I maintain the site with the Doxygen pages at 
https://bsdio.com/edk2/docs/master/ I'm all for adding function 
documentation!

I'll run the ECC tool and fix the errors.

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68969): https://edk2.groups.io/g/devel/message/68969
Mute This Topic: https://groups.io/mt/78784077/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-