回复: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD

[gaoliming]

Reviewed-by: Liming Gao <gaoliming at byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+69075+4905953+8761045 at groups.io
> <bounce+27952+69075+4905953+8761045 at groups.io> 代表 fengyunhua
> 发送时间: 2020年12月17日 9:10
> 收件人: devel at edk2.groups.io
> 抄送: Bob Feng <bob.c.feng at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Yuwei Chen <yuwei.chen at intel.com>
> 主题: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD TOKEN
> value as Zero for static PCD
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3120
> FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN.
> Their PCD TOKEN value can always be zero.
> AutoGen.h will not be changed when static PCD is added or removed.
> Dynamic PCD add or remove will still cause dynamic PCD token value be
> changed.
> 
> Cc: Bob Feng <bob.c.feng at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen at intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua at byosoft.com.cn>
> ---
>  BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> index c001828937..7d8e7b3c7c 100644
> --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> @@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen):
>                  TokenNumber += 1
> 
>          for Pcd in self.NonDynamicPcdList:
> -            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =
> TokenNumber
> -            TokenNumber += 1
> +            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] = 0
>          return RetVal
> 
>      @cached_property
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69159): https://edk2.groups.io/g/devel/message/69159
Mute This Topic: https://groups.io/mt/79051824/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-