回复: [edk2-devel] [PATCH] BaseTools: Correct report the line number in INF file issue

[gaoliming]

Create PR https://github.com/tianocore/edk2/pull/1249

> -----邮件原件-----
> 发件人: bounce+27952+69182+4905953+8761045 at groups.io
> <bounce+27952+69182+4905953+8761045 at groups.io> 代表 Bob Feng
> 发送时间: 2020年12月18日 19:11
> 收件人: Yunhua Feng <fengyunhua at byosoft.com.cn>; devel at edk2.groups.io
> 抄送: Liming Gao <gaoliming at byosoft.com.cn>; Chen, Christine
> <yuwei.chen at intel.com>
> 主题: Re: [edk2-devel] [PATCH] BaseTools: Correct report the line number
in
> INF file issue
> 
> Reviewed-by: Bob Feng <bob.c.feng at intel.com>
> 
> -----Original Message-----
> From: Yunhua Feng <fengyunhua at byosoft.com.cn>
> Sent: Friday, December 18, 2020 11:08 AM
> To: devel at edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng at intel.com>; Liming Gao
> <gaoliming at byosoft.com.cn>; Chen, Christine <yuwei.chen at intel.com>
> Subject: [PATCH] BaseTools: Correct report the line number in INF file
issue
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3127
> 
> If one protocol is not found in package dec file, Build will report the
error
> message that module.inf(-1): error 4000: Value of Protocol
[gXxxProtocolGuid]
> is not found under [Protocols] section in MdePkg.dec.
> 
> Here, -1 should be the line number of this protocol in module INF file.
> 
> Cc: Bob Feng <bob.c.feng at intel.com>
> Cc: Liming Gao <gaoliming at byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen at intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua at byosoft.com.cn>
> ---
>  BaseTools/Source/Python/Workspace/MetaFileTable.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Workspace/MetaFileTable.py
> b/BaseTools/Source/Python/Workspace/MetaFileTable.py
> index 20cb80e36e..bebf9062e8 100644
> --- a/BaseTools/Source/Python/Workspace/MetaFileTable.py
> +++ b/BaseTools/Source/Python/Workspace/MetaFileTable.py
> @@ -154,7 +154,7 @@ class ModuleTable(MetaFileTable):
>          if BelongsToItem is not None:
>              result = [item for item in result if item[7] ==
BelongsToItem]
> 
> -        result = [ [r[2],r[3],r[4],r[5],r[6],r[0],r[9]] for r in result ]
> +        result = [ [r[2],r[3],r[4],r[5],r[6],r[0],r[8]] for r in result
> + ]
>          return result
> 
>  ## Python class representation of table storing package data
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#69285): https://edk2.groups.io/g/devel/message/69285
Mute This Topic: https://groups.io/mt/79117519/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-