[edk2-devel] [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB

Liming Gao liming.gao at intel.com
Tue Feb 4 06:52:12 UTC 2020


Reviewed-by: Liming Gao <liming.gao at intel.com>

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu at intel.com>
> Sent: Tuesday, February 4, 2020 10:21 AM
> To: devel at edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <liming.gao at intel.com>
> Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
> 
> Avoid using __clang__ to specify CLANGPDB because this macro is also defined
> in CLANG38 and this causes CLANG38 build failure.
> 
> Cc: Michael D Kinney <michael.d.kinney at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu at intel.com>
> ---
>  MdePkg/Include/Base.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index 321d729c04..53fa6dca04 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -623,7 +623,7 @@ typedef char* VA_LIST;
> 
>  #elif defined(__GNUC__) || defined(__clang__)
> 
> -#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) && !defined(__clang__)
> +#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS)
>  //
>  // X64 only. Use MS ABI version of GCC built-in macros for variable argument lists.
>  //
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53698): https://edk2.groups.io/g/devel/message/53698
Mute This Topic: https://groups.io/mt/70964011/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list