[edk2-devel] [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

[Laszlo Ersek]

On 02/12/20 03:52, Ni, Ray wrote:
> 
>> +EFI_STATUS
>> +PlatformShadowMicrocode (
>> +  IN OUT CPU_MP_DATA             *CpuMpData
>> +  )
>> +{
>> +  return EFI_UNSUPPORTED;
>> +}
> 
> Siyuan,
> Better to have comments above "return EFI_UNSUPPORTED" to clarify the
> existing supporting scope.
> 
> With that, Reviewed-by: Ray Ni <ray.ni at intel.com>
> 
> + Mike for potential comments since he was involved in the offline discussion
> and the final patch doesn't exactly reflect the discussion output.

OK, I'll wait with my ACK until Mike's approval then. Otherwise the v2
changes look OK to me (including your request for more comments).

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54276): https://edk2.groups.io/g/devel/message/54276
Mute This Topic: https://groups.io/mt/71166759/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-