[edk2-devel] [PATCH 6/6] ArmPkg/ArmLib: deprecate set/way cache maintenance routines

Ard Biesheuvel ard.biesheuvel at linaro.org
Wed Feb 26 10:03:53 UTC 2020


Cache maintenance on ARMv7 systems and up should be done by virtual
address if the purpose is to manage the cached state of contents of
memory. Set/way operations are only intended to maintain the caches
themselves, e.g., to ensure that the contents of dirty cachelines
are brought to main memory before the core is powered off entirely.

UEFI on ARM is typically not involved in the latter at all, and any
cache maintenance it does is to ensure that the memory it occupies
and modifies remains in a consistent state with respect to the
caches.

So let's deprecate the set/way routines now that we have removed all
uses of it in the core code.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
---
 ArmPkg/Include/Library/ArmLib.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h
index 5a27b7c2fc27..8330339302ca 100644
--- a/ArmPkg/Include/Library/ArmLib.h
+++ b/ArmPkg/Include/Library/ArmLib.h
@@ -156,6 +156,8 @@ ArmIsMpCore (
   VOID
   );
 
+#ifndef DISABLE_NEW_DEPRECATED_INTERFACES
+
 VOID
 EFIAPI
 ArmInvalidateDataCache (
@@ -169,6 +171,8 @@ ArmCleanInvalidateDataCache (
   VOID
   );
 
+#endif
+
 VOID
 EFIAPI
 ArmCleanDataCache (
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54852): https://edk2.groups.io/g/devel/message/54852
Mute This Topic: https://groups.io/mt/71562852/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list