[edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

[Michael D Kinney]

Laszlo,

Sorry for the delay in getting to these PactchCheck.py updates.
I know it is frustrating to be blocked by these types of issues.
I try to look at 2406 tomorrow.  I think the manual override is
potentially more complex to implement than the requested changed
to PatchCheck.py.

You were on the correct link.  If you clicked one more level on
"Bash exited with code '255'" link on that web page, it takes you
to the patch check log that shows 3 errors for commit message
subject lines being too long.

https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3459&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=9c939e41-62c2-5605-5e05-fc3554afc9f5&l=149

Best regards,

Mike

> -----Original Message-----
> From: Laszlo Ersek <lersek at redhat.com>
> Sent: Monday, January 6, 2020 9:29 AM
> To: devel at edk2.groups.io; Kinney, Michael D
> <michael.d.kinney at intel.com>; Sean Brogan
> <sean.brogan at microsoft.com>; Bret Barkelew
> <Bret.Barkelew at microsoft.com>; Gao, Liming
> <liming.gao at intel.com>
> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> CI is now active on edk2/master
> 
> Hi Mike,
> 
> On 11/12/19 03:55, Michael D Kinney wrote:
> > EDK II Maintainers,
> >
> > EDK II CI Phase 1 feature is now active on
> edk2/master.
> >
> > Please use a GitHub pull request from a branch in a
> personal
> > fork of the edk2 repository with a 'push' label to
> request
> > a set of patches to be pushed to edk2/master.  The
> GitHub PR
> > replaces the 'git push' operation currently used to
> commit
> > changes to edk2/master.
> >
> > You will need to configure your notifications from
> the edk2
> > repository to make sure you receive email
> notifications
> > when the checks against the GitHub PR passes or
> fails.
> >
> > If you submit a GitHub Pull Request without the
> 'push'
> > label, then the CI checks are run and the results are
> > generated.
> >
> > Please let us know if there are any questions about
> this
> > change in the development process.
> 
> I had filed
> 
>   https://bugzilla.tianocore.org/show_bug.cgi?id=2406
> 
> a month ago, about PatchCheck.py being too strict, and
> blocking pull requests unjustifiedly.
> 
> Now I realize I can't even review the results (= the
> PatchCheck.py error messages) on github.com and/or on
> Azure Pipelines:
> 
> 
> https://github.com/tianocore/edk2/pull/272/checks?check
> _run_id=375969977
>   https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-
> 8b13-7def1f19d478/_build/results?buildId=3456
> 
> Am I looking in the wrong place perhaps?
> 
> Can we please add a manual PatchCheck.py override on
> github.com for those maintainers that are permitted to
> set the "push" label already?
> 
> TianoCore#2406 doesn't seem to be getting any
> attention, and it is blocking actual development work.
> 
> Thanks
> Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52939): https://edk2.groups.io/g/devel/message/52939
Mute This Topic: https://groups.io/mt/53725670/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-