[edk2-devel] [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER

Ard Biesheuvel ard.biesheuvel at linaro.org
Wed Jan 8 12:41:14 UTC 2020


On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude <philmd at redhat.com> wrote:
>
> Correctly write 'EFI_INVALID_PARAMETER' in documentation.
>
> Cc: Leif Lindholm <leif.lindholm at linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> Signed-off-by: Philippe Mathieu-Daude <philmd at redhat.com>
> ---
>  .../VirtualKeyboardDxe/VirtualKeyboard.h      | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>

> diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> index 8757b678d161..29bc7a06fb16 100644
> --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h
> @@ -206,9 +206,9 @@ VirtualKeyboardDriverBindingStop (
>                                  This and the language specified by Language was
>                                  returned in DriverName.
>
> -  @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
> +  @retval EFI_INVALID_PARAMETER Language is NULL.
>
> -  @retval EFI_INVALID_PAVIRTUALETER DriverName is NULL.
> +  @retval EFI_INVALID_PARAMETER DriverName is NULL.
>
>    @retval EFI_UNSUPPORTED       The driver specified by This does not support
>                                  the language specified by Language.
> @@ -274,14 +274,14 @@ VirtualKeyboardComponentNameGetDriverName (
>                                  driver specified by This was returned in
>                                  DriverName.
>
> -  @retval EFI_INVALID_PAVIRTUALETER ControllerHandle is NULL.
> +  @retval EFI_INVALID_PARAMETER ControllerHandle is NULL.
>
> -  @retval EFI_INVALID_PAVIRTUALETER ChildHandle is not NULL and it is not a valid
> +  @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a valid
>                                  EFI_HANDLE.
>
> -  @retval EFI_INVALID_PAVIRTUALETER Language is NULL.
> +  @retval EFI_INVALID_PARAMETER Language is NULL.
>
> -  @retval EFI_INVALID_PAVIRTUALETER ControllerName is NULL.
> +  @retval EFI_INVALID_PARAMETER ControllerName is NULL.
>
>    @retval EFI_UNSUPPORTED       The driver specified by This is not currently
>                                  managing the controller specified by
> @@ -351,7 +351,7 @@ VirtualKeyboardResetEx (
>    @retval EFI_DEVICE_ERROR      The device is not functioning correctly and could
>                                  not have the setting adjusted.
>    @retval EFI_UNSUPPORTED       The device does not have the ability to set its state.
> -  @retval EFI_INVALID_PAVIRTUALETER KeyToggleState is NULL.
> +  @retval EFI_INVALID_PARAMETER KeyToggleState is NULL.
>
>  **/
>  EFI_STATUS
> @@ -374,7 +374,7 @@ VirtualKeyboardSetState (
>
>    @retval EFI_SUCCESS             The notification function was registered successfully.
>    @retval EFI_OUT_OF_RESOURCES    Unable to allocate resources for necesssary data structures.
> -  @retval EFI_INVALID_PAVIRTUALETER   KeyData or NotifyHandle is NULL.
> +  @retval EFI_INVALID_PARAMETER   KeyData or NotifyHandle is NULL.
>
>  **/
>  EFI_STATUS
> @@ -393,7 +393,7 @@ VirtualKeyboardRegisterKeyNotify (
>    @param  NotificationHandle   The handle of the notification function being unregistered.
>
>    @retval EFI_SUCCESS             The notification function was unregistered successfully.
> -  @retval EFI_INVALID_PAVIRTUALETER   The NotificationHandle is invalid.
> +  @retval EFI_INVALID_PARAMETER   The NotificationHandle is invalid.
>
>  **/
>  EFI_STATUS
> @@ -412,7 +412,7 @@ VirtualKeyboardUnregisterKeyNotify (
>    @param  ListHead   The list head
>
>    @retval EFI_SUCCESS           Free the notify list successfully
> -  @retval EFI_INVALID_PAVIRTUALETER ListHead is invalid.
> +  @retval EFI_INVALID_PARAMETER ListHead is invalid.
>
>  **/
>  EFI_STATUS
> @@ -524,7 +524,7 @@ VirtualKeyboardReadKeyStroke (
>    @retval  EFI_NOT_READY         There was no keystroke data availiable.
>    @retval  EFI_DEVICE_ERROR      The keystroke information was not returned due to
>                                   hardware errors.
> -  @retval  EFI_INVALID_PAVIRTUALETER KeyData is NULL.
> +  @retval  EFI_INVALID_PARAMETER KeyData is NULL.
>
>  **/
>  EFI_STATUS
> --
> 2.21.0
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53014): https://edk2.groups.io/g/devel/message/53014
Mute This Topic: https://groups.io/mt/69395701/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list