[edk2-devel] [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

[Gao, Zhichao]

Ray,
I prefer to merge these two lib instance into one folder and remove the duplicated code.
I can change all the required change in open source repo. But not sure how many close source platforms would be affected.
This action should make all the close platform owners aware of it and changing their platform code to consume the new lib instance.

#2: OK. That makes sense to consume the new device path node if appear.

Thanks,
Zhichao

From: Ni, Ray
Sent: Friday, January 10, 2020 3:36 PM
To: Gao, Zhichao <zhichao.gao at intel.com>; devel at edk2.groups.io; 'rfc at edk2.groups.io' <rfc at edk2.groups.io>
Cc: Gao, Liming <liming.gao at intel.com>; Kinney, Michael D <michael.d.kinney at intel.com>; vit9696 at protonmail.com
Subject: RE: [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

Zhichao,
What's your recommendation regarding this?

Back to your 2nd question, drivers/applications consuming UefiDevicePathLibOptionalDevicePathProtocol
can firstly use the firmware built-in from-text and to-text conversion, then use its own conversion logic if
the firmware doesn't contain built-in from-text or to-text conversion.
Considering a case that an application is released in year 2015, it can recognize the new device path node
introduced after 2015 in a new system.

Thanks,
Ray

From: Gao, Zhichao <zhichao.gao at intel.com<mailto:zhichao.gao at intel.com>>
Sent: Friday, January 10, 2020 11:04 AM
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; 'rfc at edk2.groups.io' <rfc at edk2.groups.io<mailto:rfc at edk2.groups.io>>
Cc: Gao, Liming <liming.gao at intel.com<mailto:liming.gao at intel.com>>; Kinney, Michael D <michael.d.kinney at intel.com<mailto:michael.d.kinney at intel.com>>; vit9696 at protonmail.com<mailto:vit9696 at protonmail.com>; Ni, Ray <ray.ni at intel.com<mailto:ray.ni at intel.com>>
Subject: [RFC] BZ 2298 MdePkg/DevicePathLib merger or not

HI all,

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
In the MdePkg, there are two folder for the DevicePathLib:

  1.  MdePkg\Library\UefiDevicePathLib
  2.  MdePkg\Library\UefiDevicePathLibDevicePathProtocol

UefiDevicePathLibDevicePathProtocol is created to use the protocol to reduce the driver size which consume the DevicePathLib.
But it has duplicate code with #1. So I want to merge these two folder into one. But many platform implementations consume #2.
If we merge #2 into #1, there might be a lot of platform changes for both close source and open source.
Can anyone give me some suggestions about this? Do we have a progress to retire some implementation in the edk2 repor?

There is another question about MdePkg\Library\UefiDevicePathLib\UefiDevicePathLibOptionalDevicePathProtocol.inf.
This one implements the interface to choose the protocol first, then change to local implementation if no protocol is available.
It requires a fix and it is already sent to the community. But what's the purpose?
Local implementation, i.e. MdePkg\Library\UefiDevicePathLib\ UefiDevicePathLib.inf, can make sure its usable. And it can't reduce the driver size. If it is useless, can we directly remove it?

Thanks,
Zhichao


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53142): https://edk2.groups.io/g/devel/message/53142
Mute This Topic: https://groups.io/mt/69593973/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200110/f0b54719/attachment.htm>