[edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

[Ashish Singhal]

Hello Zhichao,

Do you know by when this may be merged?

Thanks
Ashish

-----Original Message-----
From: Gao, Zhichao <zhichao.gao at intel.com> 
Sent: Monday, January 20, 2020 12:42 AM
To: devel at edk2.groups.io; Ashish Singhal <ashishsingha at nvidia.com>; Ni, Ray <ray.ni at intel.com>
Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix FADT Parser

External email: Use caution opening links or attachments


Reviewed-by: Zhichao Gao <zhichao.gao at intel.com>

> -----Original Message-----
> From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of 
> Ashish Singhal
> Sent: Monday, January 20, 2020 1:45 PM
> To: devel at edk2.groups.io; Ni, Ray <ray.ni at intel.com>; Gao, Zhichao 
> <zhichao.gao at intel.com>
> Cc: Ashish Singhal <ashishsingha at nvidia.com>
> Subject: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: 
> Fix FADT Parser
>
> FADT parser was checking for reduced ACPI flag incorrectly leading to 
> incorrect error message if FIRMWARE_CTRL and X_FIRMWARE_CTRL are both 
> 0.
>
> Signed-off-by: Ashish Singhal <ashishsingha at nvidia.com>
> ---
>  .../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> index 5b8cc174f1..8acfbac3b1 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtPars
> +++ er.c
> @@ -253,7 +253,7 @@ ParseAcpiFadt (
>      // present.
>      if ((Trace) &&
>          (Flags != NULL) &&
> -        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) != 0)) {
> +        ((*Flags & EFI_ACPI_6_3_HW_REDUCED_ACPI) !=
> + EFI_ACPI_6_3_HW_REDUCED_ACPI)) {
>        IncrementErrorCount ();
>        Print (L"ERROR: No FACS table found, "
>                 L"both X_FIRMWARE_CTRL and FIRMWARE_CTRL are 
> zero.\n");
> --
> 2.17.1
>
>
> 

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53486): https://edk2.groups.io/g/devel/message/53486
Mute This Topic: https://groups.io/mt/69926879/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-