[edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

[Michael D Kinney]

Hi Laszlo,

I suspect the behavior you observed was due to the
PR being opened, which triggers the CI actions
immediately.  Then you set the 'push' label, which 
was not seen when the PR was opened.  This required
a second pass which you did by re-opening.

There are 2 approaches a maintainer can take:

1) Open PR without 'push' label.  Wait for CI checks
   to run and review status.  If all pass, then set 
   the 'push' label and re-open.  This option does
   cause 2 passes through the CI checks for a good
   patch series.

2) Open PR with the 'push' label set.  If all checks
   pass, then it is merged.  If any checks fail, then
   the maintainer can address and do a forced push to 
   their branch to retry.

Mike

> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On
> Behalf Of Laszlo Ersek
> Sent: Friday, January 31, 2020 1:28 AM
> To: Kinney, Michael D <michael.d.kinney at intel.com>;
> devel at edk2.groups.io
> Cc: Zhang, Chao B <chao.b.zhang at intel.com>; Wang, Jian
> J <jian.j.wang at intel.com>; Yao, Jiewen
> <jiewen.yao at intel.com>
> Subject: Re: [edk2-devel] [PATCH 00/11]
> SecurityPkg/DxeImageVerificationHandler: fix retval for
> "deny" policy
> 
> Hi Mike,
> 
> On 01/31/20 09:12, Laszlo Ersek wrote:
> 
> > So let me push this series as-is for TianoCore#2129,
> with your R-b
> > applied.
> 
> My pull request (with the "push" label set) seems to
> have stalled. The
> checks have passed (twice -- I closed and reopened the
> PR once, to
> re-trigger mergify), but the branch is not being
> merged.
> 
> https://github.com/tianocore/edk2/pull/324
> 
> Thanks
> Laszlo
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53609): https://edk2.groups.io/g/devel/message/53609
Mute This Topic: https://groups.io/mt/69752218/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-