[edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci
Michael D Kinney
michael.d.kinney at intel.com
Wed Jul 29 01:32:33 UTC 2020
Hi Liming,
There are exception to PatchCheck as well for line endings and tabs.
Seems like a similar problem, and a single CI plugin could
support all these cases.
Mike
> -----Original Message-----
> From: Gao, Liming <liming.gao at intel.com>
> Sent: Tuesday, July 28, 2020 6:12 PM
> To: Kinney, Michael D <michael.d.kinney at intel.com>;
> Zhang, Shenglei <shenglei.zhang at intel.com>;
> devel at edk2.groups.io
> Cc: Sean Brogan <sean.brogan at microsoft.com>; Bret
> Barkelew <Bret.Barkelew at microsoft.com>; Dong, Eric
> <eric.dong at intel.com>; Laszlo Ersek <lersek at redhat.com>;
> Gao, Zhichao <zhichao.gao at intel.com>; Yao, Jiewen
> <jiewen.yao at intel.com>; Chao Zhang
> <chao.b.zhang at intel.com>; Justen, Jordan L
> <jordan.l.justen at intel.com>; Maciej Rabeda
> <maciej.rabeda at linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>;
> Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A
> <hao.a.wu at intel.com>; Andrew Fish <afish at apple.com>; Ni,
> Ray <ray.ni at intel.com>; Lu, XiaoyuX
> <xiaoyux.lu at intel.com>; Ard Biesheuvel
> <ard.biesheuvel at arm.com>; Leif Lindholm
> <leif at nuviainc.com>; Gao, Liming <liming.gao at intel.com>
> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
>
> Mike:
> Previous discussion
> (https://edk2.groups.io/g/devel/message/62494) is to
> revert the license check change in PatchCheck, and
> enable license check as plugin. If so, the package
> maintainers can configure the package level exception
> list to allow some special cases, such as autogen file.
>
> Thanks
> Liming
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney at intel.com>
> Sent: 2020年7月29日 7:34
> To: Zhang, Shenglei <shenglei.zhang at intel.com>;
> devel at edk2.groups.io; Kinney, Michael D
> <michael.d.kinney at intel.com>
> Cc: Sean Brogan <sean.brogan at microsoft.com>; Bret
> Barkelew <Bret.Barkelew at microsoft.com>; Dong, Eric
> <eric.dong at intel.com>; Laszlo Ersek <lersek at redhat.com>;
> Gao, Zhichao <zhichao.gao at intel.com>; Yao, Jiewen
> <jiewen.yao at intel.com>; Chao Zhang
> <chao.b.zhang at intel.com>; Justen, Jordan L
> <jordan.l.justen at intel.com>; Maciej Rabeda
> <maciej.rabeda at linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu at intel.com>; Fu, Siyuan <siyuan.fu at intel.com>;
> Gao, Liming <liming.gao at intel.com>; Wang, Jian J
> <jian.j.wang at intel.com>; Wu, Hao A <hao.a.wu at intel.com>;
> Andrew Fish <afish at apple.com>; Ni, Ray
> <ray.ni at intel.com>; Lu, XiaoyuX <xiaoyux.lu at intel.com>;
> Ard Biesheuvel <ard.biesheuvel at arm.com>; Leif Lindholm
> <leif at nuviainc.com>
> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
>
> CI already runs PatchCheck. If we ported PatchCheck to
> a CI plugin, then the plugin could perform both the
> current PatchCheck features and the license check.
>
> What this option evaluated?
>
> If we did provide PatchCheck as a CI plugin, developers
> I believe developers could run a stuart command likely
> for the NOOPT target to run a PatchCheck CI plugin
> locally.
>
> Thanks,
>
> Mike
>
> > -----Original Message-----
> > From: Zhang, Shenglei <shenglei.zhang at intel.com>
> > Sent: Monday, July 20, 2020 1:37 AM
> > To: devel at edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney at intel.com>;
> Sean Brogan
> > <sean.brogan at microsoft.com>; Bret Barkelew
> > <Bret.Barkelew at microsoft.com>; Dong, Eric
> <eric.dong at intel.com>;
> > Laszlo Ersek <lersek at redhat.com>; Gao, Zhichao
> > <zhichao.gao at intel.com>; Yao, Jiewen
> <jiewen.yao at intel.com>; Chao
> > Zhang <chao.b.zhang at intel.com>; Justen, Jordan L
> > <jordan.l.justen at intel.com>; Maciej Rabeda
> > <maciej.rabeda at linux.intel.com>; Wu, Jiaxin
> <jiaxin.wu at intel.com>; Fu,
> > Siyuan <siyuan.fu at intel.com>; Gao, Liming
> <liming.gao at intel.com>;
> > Wang, Jian J <jian.j.wang at intel.com>; Wu, Hao A
> <hao.a.wu at intel.com>;
> > Andrew Fish <afish at apple.com>; Ni, Ray
> <ray.ni at intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu at intel.com>; Ard Biesheuvel
> <ard.biesheuvel at arm.com>; Leif
> > Lindholm <leif at nuviainc.com>
> > Subject: [PATCH 00/15] Add a plugin LicenseCheck in
> open ci
> >
> > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2691
> > REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=2833
> > LicenseCheck is now enabled in PatchCheck.py. But
> there's a patch
> > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
> > to suggest revert the change.These patch series
> introduce a plugin
> > LicenseCheck into open ci so that license issues can
> still be checked
> > after the checker is disabled in PatchCheck.py.
> > 1/15 is the plugin implementation.
> > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow
> developers to
> > skip license check for some files like generated
> files.
> >
> > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can
> pass this
> > checker.
> >
> > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > Cc: Sean Brogan <sean.brogan at microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> > Cc: Eric Dong <eric.dong at intel.com>
> > Cc: Laszlo Ersek <lersek at redhat.com>
> > Cc: Zhichao Gao <zhichao.gao at intel.com>
> > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > Cc: Chao Zhang <chao.b.zhang at intel.com>
> > Cc: Jordan Justen <jordan.l.justen at intel.com>
> > Cc: Maciej Rabeda <maciej.rabeda at linux.intel.com>
> > Cc: Jiaxin Wu <jiaxin.wu at intel.com>
> > Cc: Siyuan Fu <siyuan.fu at intel.com>
> > Cc: Liming Gao <liming.gao at intel.com>
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Hao A Wu <hao.a.wu at intel.com>
> > Cc: Jordan Justen <jordan.l.justen at intel.com>
> > Cc: Andrew Fish <afish at apple.com>
> > Cc: Ray Ni <ray.ni at intel.com>
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu at intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
> > Cc: Leif Lindholm <leif at nuviainc.com>
> > Shenglei Zhang (15):
> > .pytool/Plugin: Add a plugin LicenseCheck
> > FatPkg/FatPkg.ci.yaml: Add configuration for
> LicenseCheck
> > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for
> LicenseCheck
> > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for
> LicenseCheck
> > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration
> for LicenseCheck
> > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration
> for
> > LicenseCheck
> > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration
> for
> > LicenseCheck
> > MdePkg/MdePkg.ci.yaml: Add configuration for
> LicenseCheck
> > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for
> LicenseCheck
> > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for
> LicenseCheck
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add
> configuration for
> > LicenseCheck
> > SecurityPkg/SecurityPkg.ci.yaml: Add configuration
> for LicenseCheck
> > ShellPkg/ShellPkg.ci.yaml: Add configuration for
> LicenseCheck
> > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for
> LicenseCheck
> > UnitTestFrameworkPkg: Add configuration for
> LicenseCheck in yaml
> > file
> >
> > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118
> > ++++++++++++++++++
> > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11
> ++
> > .pytool/Plugin/LicenseCheck/Readme.md | 17
> +++
> > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 +
> > CryptoPkg/CryptoPkg.ci.yaml | 3 +
> > EmulatorPkg/EmulatorPkg.ci.yaml | 4 +
> > FatPkg/FatPkg.ci.yaml | 3 +
> > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +
> > MdeModulePkg/MdeModulePkg.ci.yaml | 4 +
> > MdePkg/MdePkg.ci.yaml | 4 +
> > NetworkPkg/NetworkPkg.ci.yaml | 3 +
> > OvmfPkg/OvmfPkg.ci.yaml | 4 +
> > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +
> > SecurityPkg/SecurityPkg.ci.yaml | 3 +
> > ShellPkg/ShellPkg.ci.yaml | 3 +
> > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +
> > .../UnitTestFrameworkPkg.ci.yaml | 4 +
> > 17 files changed, 194 insertions(+)
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/LicenseCheck.py
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml
> > create mode 100644
> > .pytool/Plugin/LicenseCheck/Readme.md
> >
> > --
> > 2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63427): https://edk2.groups.io/g/devel/message/63427
Mute This Topic: https://groups.io/mt/75678207/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list