[edk2-devel] [edk2-platform][PATCH v3 0/6] Update ASIX USB Networking drivers

Samer El-Haj-Mahmoud samer.el-haj-mahmoud at arm.com
Mon Jun 8 13:38:26 UTC 2020


This series updates the ASIX USB networking drivers:

 - Create new Drivers/ASIX/ package
 - Add new ASIX drivers Ax88179 and Ax88772c to the new ASIX package
 - Delete old Ax88772 and Ax88772b drivers from OptionRomPkg

Code pushed to https://github.com/samerhaj/edk2-platforms/tree/asix_usb_nic_drivers_ver3

version 1: https://edk2.groups.io/g/devel/message/58771
version 2: https://edk2.groups.io/g/devel/message/58986
version 3 changes:
 - Rename AsixPkg to ASIX [Ray]
 - Changed SNP Mode->IfType from EfiNetworkInterfaceUndi to
   NET_IFTYPE_ETHERNET [Ard]
 - Dropped runtime module types and associated depex, libraries,
   and memory allocation [Ard]
 - Dropped "SCT_PASS" and kept the enable logic [Leif]
 - Dropped dead / commented out code and macros
   (including "ARM" and "AMI") [Ard, Leif]
 - Dropped unused debug macros [Leif, Ard]
 - Dropped "Freddy" Comments and unused macros [Leif, Ard]
 - Dropped inorrect VALID_ARCHITECTURES from INF files [Ard]
 - Dropped all Hungarian notation variables [Ard, Leif]
 - Dropped 'Yoda-style' compariosns [Ard, Leif]
 - Dropped redundant casts [Ard]
 - Fixed spacing, indentation, and curly braces [Ard, Leif]
 - Used CamelCase definitions per coding style [Ard]
 - Dropped 'success handling' [Ard]
 - Sorted LibraryClasses and include files [Ard]
 - Aligned variables and function parameters declarations [Ard]
 - Cleaned up include headers [Leif]
 - Added public link to orignal ASIX provided code [Leif]

Cc: Ray Ni <ray.ni at intel.com>
Cc: Leif Lindholm <leif at nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel at arm.com>
Cc: Michael D Kinney <michael.d.kinney at intel.com>
Cc: Pete Batard <pete at akeo.ie>
Cc: Andrei Warkentin <andrey.warkentin at gmail.com>

Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud at arm.com>

Samer El-Haj-Mahmoud (6):
  Drivers/ASIX: Create ASIX drivers package
  Drivers/ASIX: Add ASIX Ax88179 driver
  Drivers/ASIX: Add ASIX Ax88772c driver
  Platform/RaspberryPi: Switch RPi3 USB NIC driver to Ax88772c
  Platform/HiSilicon: Switch HiKey USB NIC driver to Ax88772c
  Drivers/OptionRomPkg: Remove old ASIX NIC drivers

 Drivers/ASIX/Asix.dec                         |   30 +
 Drivers/ASIX/Asix.dsc                         |   68 +
 Drivers/OptionRomPkg/OptionRomPkg.dsc         |    3 +-
 Platform/Hisilicon/HiKey/HiKey.dsc            |    2 +-
 Platform/RaspberryPi/RPi3/RPi3.dsc            |    2 +-
 Platform/Hisilicon/HiKey/HiKey.fdf            |    2 +-
 Platform/RaspberryPi/RPi3/RPi3.fdf            |    2 +-
 .../Bus/Usb/UsbNetworking/Ax88179/Ax88179.inf |   45 +
 .../Usb/UsbNetworking/Ax88772c/Ax88772c.inf}  |   28 +-
 .../Usb/UsbNetworking/Ax88772b/Ax88772b.inf   |   61 -
 .../Bus/Usb/UsbNetworking/Ax88179/Ax88179.h}  |  792 ++++----
 .../Bus/Usb/UsbNetworking/Ax88772c}/Ax88772.h |  489 ++---
 .../Bus/Usb/UsbNetworking/Ax88179/Ax88179.c   | 1042 +++++++++++
 .../UsbNetworking/Ax88179}/ComponentName.c    |  107 +-
 .../Usb/UsbNetworking/Ax88179/DriverBinding.c |  639 +++++++
 .../Usb/UsbNetworking/Ax88179/SimpleNetwork.c | 1548 +++++++++++++++
 .../Bus/Usb/UsbNetworking/Ax88772c/Ax88772.c  | 1300 +++++++++++++
 .../UsbNetworking/Ax88772c}/ComponentName.c   |   97 +-
 .../UsbNetworking/Ax88772c/DriverBinding.c    |  652 +++++++
 .../UsbNetworking/Ax88772c/SimpleNetwork.c    | 1581 ++++++++++++++++
 .../Bus/Usb/UsbNetworking/Ax88772/Ax88772.c   | 1318 -------------
 .../Usb/UsbNetworking/Ax88772/DriverBinding.c |  507 -----
 .../Usb/UsbNetworking/Ax88772/SimpleNetwork.c | 1503 ---------------
 .../Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c  |  875 ---------
 .../UsbNetworking/Ax88772b/DriverBinding.c    |  696 -------
 .../UsbNetworking/Ax88772b/SimpleNetwork.c    | 1657 -----------------
 26 files changed, 7754 insertions(+), 7292 deletions(-)
 create mode 100644 Drivers/ASIX/Asix.dec
 create mode 100644 Drivers/ASIX/Asix.dsc
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88179/Ax88179.inf
 rename Drivers/{OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.inf => ASIX/Bus/Usb/UsbNetworking/Ax88772c/Ax88772c.inf} (58%)
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772b.inf
 rename Drivers/{OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.h => ASIX/Bus/Usb/UsbNetworking/Ax88179/Ax88179.h} (52%)
 rename Drivers/{OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b => ASIX/Bus/Usb/UsbNetworking/Ax88772c}/Ax88772.h (69%)
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88179/Ax88179.c
 rename Drivers/{OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772 => ASIX/Bus/Usb/UsbNetworking/Ax88179}/ComponentName.c (69%)
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88179/DriverBinding.c
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88179/SimpleNetwork.c
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88772c/Ax88772.c
 rename Drivers/{OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b => ASIX/Bus/Usb/UsbNetworking/Ax88772c}/ComponentName.c (70%)
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88772c/DriverBinding.c
 create mode 100644 Drivers/ASIX/Bus/Usb/UsbNetworking/Ax88772c/SimpleNetwork.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/Ax88772.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/DriverBinding.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772/SimpleNetwork.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/Ax88772.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/DriverBinding.c
 delete mode 100644 Drivers/OptionRomPkg/Bus/Usb/UsbNetworking/Ax88772b/SimpleNetwork.c

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60862): https://edk2.groups.io/g/devel/message/60862
Mute This Topic: https://groups.io/mt/74751636/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list