[edk2-devel] [PATCH edk2-platforms 6/7] Platform/NXP: LX2160aRdbPkg: Enable NetworkPkg
Leif Lindholm
leif at nuviainc.com
Thu Jun 18 15:20:07 UTC 2020
On Wed, Jun 10, 2020 at 03:47:29 +0530, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan at nxp.com>
>
> Enable NetworkPkg for LX2160aRdbPkg Platform.
This is done as part of a pacthset called "enable PCIe support
for...".
Again, I understand why you're doing this, but it is far from obvious.
Please add a note to the commit message explaining *why*.
(Also, this deserves explicit pointing out in cover letter.)
> Signed-off-by: Wasim Khan <wasim.khan at nxp.com>
> ---
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 11 +++++++++++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 5 +++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> index d0ec7b5a8906..c73f9fd4d393 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
> @@ -22,6 +22,13 @@ [Defines]
> OUTPUT_DIRECTORY = Build/LX2160aRdbPkg
> FLASH_DEFINITION = Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
>
> + #
> + # Network definition
> + #
> + DEFINE NETWORK_TLS_ENABLE = FALSE
> + DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> + DEFINE NETWORK_ISCSI_ENABLE = FALSE
> +
> !include Silicon/NXP/NxpQoriqLs.dsc.inc
> !include Silicon/NXP/LX2160A/LX2160A.dsc.inc
>
> @@ -45,4 +52,8 @@ [Components.common]
>
> Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf
>
> + #
> + # Networking stack
> + #
> +!include NetworkPkg/Network.dsc.inc
> ##
> diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> index 41b8f1ececa4..4c9cab5d0938 100644
> --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf
> @@ -116,6 +116,11 @@ [FV.FvMain]
> INF ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
>
> #
> + # Networking stack
> + #
> +!include NetworkPkg/Network.fdf.inc
> +
> + #
> # FAT filesystem + GPT/MBR partitioning
> #
> INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf
> --
> 2.7.4
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61496): https://edk2.groups.io/g/devel/message/61496
Mute This Topic: https://groups.io/mt/74793007/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list