[edk2-devel] [PATCH v3 12/15] ArmVirtPkg: Support for kvmtool virtual platform

[Laszlo Ersek]

On 06/25/20 16:08, Ard Biesheuvel wrote:
> On 6/24/20 3:34 PM, Sami Mujawar wrote:

>> +!if $(ENABLE_NETWORK) == TRUE
>> +  #
>> +  # Networking stack
>> +  #
>> +  NetworkPkg/SnpDxe/SnpDxe.inf
> 
> I think we have special .inc files in NetworkPkg now for this, no?
> 
>> +  NetworkPkg/DpcDxe/DpcDxe.inf
>> +  NetworkPkg/ArpDxe/ArpDxe.inf
>> +  NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf
>> +  NetworkPkg/Ip4Dxe/Ip4Dxe.inf
>> +  NetworkPkg/MnpDxe/MnpDxe.inf
>> +  NetworkPkg/VlanConfigDxe/VlanConfigDxe.inf
>> +  NetworkPkg/Mtftp4Dxe/Mtftp4Dxe.inf
>> +  NetworkPkg/Udp4Dxe/Udp4Dxe.inf
>> +  NetworkPkg/TcpDxe/TcpDxe.inf
>> +  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
>> +  NetworkPkg/IScsiDxe/IScsiDxe.inf
>> +!endif

Yes, we do:

$ git grep -F '!include NetworkPkg/' -- ArmVirtPkg

In particular, SnpDxe is not useful (we don't have UNDI drivers on
ARM/AARCH64, which SnpDxe wraps):

!if $(NETWORK_SNP_ENABLE) == TRUE
  !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only"
!endif

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61744): https://edk2.groups.io/g/devel/message/61744
Mute This Topic: https://groups.io/mt/75081494/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-