[edk2-devel] [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86

[Liming Gao]

Daniel:
  PcdDxeIplSwitchToLongMode is only used in IA32 arch. It is also specified in [FeaturePcd.IA32] section of DxeIpl.inf. So, I don't understand why defines this PCD in other ARCH in MdeModulePkg.dec. 

Thanks
Liming
> -----Original Message-----
> From: Daniel Schaefer <daniel.schaefer at hpe.com>
> Sent: Monday, March 2, 2020 6:33 PM
> To: devel at edk2.groups.io
> Cc: Abner Chang <abner.chang at hpe.com>; Gilbert Chen <gilbert.chen at hpe.com>; Leif Lindholm <leif at nuviainc.com>; Bi, Dandan
> <dandan.bi at intel.com>; Gao, Liming <liming.gao at intel.com>
> Subject: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86
> 
> Otherwise the PCD isn't defined on other architectures.
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2548
> 
> Signed-off-by: Daniel Schaefer <daniel.schaefer at hpe.com>
> Cc: Abner Chang <abner.chang at hpe.com>
> Cc: Gilbert Chen <gilbert.chen at hpe.com>
> Cc: Leif Lindholm <leif at nuviainc.com>
> Cc: Dandan Bi <dandan.bi at intel.com>
> Cc: Liming Gao <liming.gao at intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 91a3c608231c..59645c860148 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -879,6 +879,9 @@ [PcdsFeatureFlag]
>  [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a
> 
> 
> 
> +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
> 
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN|0x0001003b
> 
> +
> 
>  [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
> 
>    ## Indicates if DxeIpl should switch to long mode to enter DXE phase.
> 
>    #  It is assumed that 64-bit DxeCore is built in firmware if it is true; otherwise 32-bit DxeCore
> 
> --
> 2.25.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55185): https://edk2.groups.io/g/devel/message/55185
Mute This Topic: https://groups.io/mt/71671269/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-