[edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: ECC issue.

GuoMinJ newexplorerj at gmail.com
Wed Mar 4 11:39:28 UTC 2020


REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2553

The comment haven't indicate the output attribute.

Cc: Eric Dong <eric.dong at intel.com>
Cc: Ray Ni <ray.ni at intel.com>
Cc: Laszlo Ersek <lersek at redhat.com>
Signed-off-by: GuoMinJ <newexplorerj at gmail.com>
---
 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +-
 UefiCpuPkg/Library/MpInitLib/MpLib.h    | 2 +-
 UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index a987c32109..096d1c9b4b 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -821,7 +821,7 @@ MpInitLibEnableDisableAP (
   This funtion will try to invoke platform specific microcode shadow logic to
   relocate microcode update patches into memory.
 
-  @param[in] CpuMpData  The pointer to CPU MP Data structure.
+  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
 
   @retval EFI_SUCCESS              Shadow microcode success.
   @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 455cb3f09a..06556197c3 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -658,7 +658,7 @@ GetProcessorNumber (
   This funtion will try to invoke platform specific microcode shadow logic to
   relocate microcode update patches into memory.
 
-  @param[in] CpuMpData  The pointer to CPU MP Data structure.
+  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
 
   @retval EFI_SUCCESS              Shadow microcode success.
   @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the operation.
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 17b60903c5..a548fed23f 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -644,7 +644,7 @@ MpInitLibEnableDisableAP (
   This funtion will try to invoke platform specific microcode shadow logic to
   relocate microcode update patches into memory.
 
-  @param[in] CpuMpData  The pointer to CPU MP Data structure.
+  @param[in, out] CpuMpData  The pointer to CPU MP Data structure.
 
   @retval EFI_SUCCESS              Shadow microcode success.
   @retval EFI_OUT_OF_RESOURCES     No enough resource to complete the operation.
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55398): https://edk2.groups.io/g/devel/message/55398
Mute This Topic: https://groups.io/mt/71724102/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list