[edk2-devel] [PATCH] OvmfPkg/OvmfXen: fix build by providing QemuLoadImageLib resolution

[Ard Biesheuvel]

On Fri, 6 Mar 2020 at 00:45, Laszlo Ersek <lersek at redhat.com> wrote:
>
> On 03/05/20 22:26, Ard Biesheuvel wrote:
> > Commit 859b55443a4253ba ("OvmfPkg/PlatformBootManagerLib: switch to
> > QemuLoadImageLib") replaced a dependency on LoadLinuxLib with one on
> > QemuLoadImageLib in the PlatformBootManagerLib implementation that is
> > shared between all OVMF builds, without taking into account that even
> > the Xen targeted builds incorporate this code, which is only used to
> > load kernels passed via the QEMU command line.
> >
> > Since this is dead code on Xen, we can satisfy the dependency using
> > the generic version of QemuLoadImageLib, which does not rely on
> > LoadLinuxLib, which we can therefore drop from OvmfXen.dsc.
> >
> > Fixes: 859b55443a4253bad8bb618d04a51b2ded67f24b
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > ---
> >  OvmfPkg/OvmfXen.dsc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> > index d476694b18d5..85fe39f7896c 100644
> > --- a/OvmfPkg/OvmfXen.dsc
> > +++ b/OvmfPkg/OvmfXen.dsc
> > @@ -151,7 +151,7 @@ [LibraryClasses]
> >    UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> >    SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf
> >    QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf
> > -  LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf
> > +  QemuLoadImageLib|OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.inf
> >    MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf
> >    LockBoxLib|OvmfPkg/Library/LockBoxLib/LockBoxBaseLib.inf
> >    CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf
> >
>
> Reviewed-by: Laszlo Ersek <lersek at redhat.com>
>


Pushed as  1f3b1eb30822..80681884319d

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55587): https://edk2.groups.io/g/devel/message/55587
Mute This Topic: https://groups.io/mt/71759233/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-