[edk2-devel] [RFC][PATCH v1] UefiCpuPkg/MpInitLib DXE: Reduce AP status check interval

[Ni, Ray]

> The use case is valid, IMO. And the commit message is helpful.
> 
> But I really think this constant should be PCD. Here's why I think a
> platform might want to control it:
> 
> - The best (finest) possible resolution for timer events is platform
> dependent, IIUC. The duration of the "idle tick" is platform-specific.
> And, it likely makes no sense to set AP_CHECK_INTERVAL to a duration
> that's around, or under, what the arch timer resolution allows for.
> 
> - In the other direction, CheckAndUpdateApsStatus() contains a loop that
> counts up to CpuMpData->CpuCount. In a very large system (hundreds or
> maybe thousands of APs) this function may have non-negligible cost.
> 
> I suggest introducing a PCD for this (measured in msecs) and using 100
> msecs as the default.

Laszlo,
Adding a PCD means platform integrators need to consider which value to set.
Most of the time, they may just use the default PCD value.
Then, why not we add the PCD later when a real case is met?

Thanks,
Ray

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55860): https://edk2.groups.io/g/devel/message/55860
Mute This Topic: https://groups.io/mt/71925352/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-