[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
Ni, Ray
ray.ni at intel.com
Wed Mar 18 08:09:33 UTC 2020
Reviewed-by: Ray Ni <ray.ni at intel.com>
> -----Original Message-----
> From: Jiang, Guomin <guomin.jiang at intel.com>
> Sent: Wednesday, March 18, 2020 4:08 PM
> To: devel at edk2.groups.io
> Cc: Jiang, Guomin <guomin.jiang at intel.com>; Ni, Ray <ray.ni at intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty at intel.com>
> Subject: [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR
>
> From: Guomin Jiang <guomin.jiang at intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589
>
> According to code logic, it just judge the condition rather than the
> status, it should use the ASSERT rather than ASSERT_EFI_ERROR.
>
> Cc: Ray Ni <ray.ni at intel.com>
> Cc: Rangasai V Chaganty <rangasai.v.chaganty at intel.com>
> Signed-off-by: Guomin Jiang <guomin.jiang at intel.com>
> ---
> .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> index 29b6916f61..aa2bf14fa8 100644
> --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
> @@ -69,7 +69,7 @@ RecordPciDeviceInList(
> ASSERT_EFI_ERROR(Status);
>
>
>
> NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
>
> - ASSERT_EFI_ERROR(NewPciDevice != NULL);
>
> + ASSERT(NewPciDevice != NULL);
>
>
>
> NewPciDevice->Signature = PCI_DEVICE_INSTANCE_SIGNATURE;
>
> NewPciDevice->PciSegment = PciSegment;
>
> --
> 2.25.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55952): https://edk2.groups.io/g/devel/message/55952
Mute This Topic: https://groups.io/mt/72044540/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list