[edk2-devel] [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform
Pankaj Bansal
pankaj.bansal at oss.nxp.com
Fri Mar 20 14:35:15 UTC 2020
From: Pankaj Bansal <pankaj.bansal at nxp.com>
This patch series adds PEI phase to NXP LS1043ARDB Platform.
The previous attempt at this feature can be referred here:
https://edk2.groups.io/g/devel/message/54006
I have taken care of the review comments received on v1 and have
broken down the patches further to make review easier.
That is why the number of patches have increased from 19 in v1 to
28 in v2.
As such the v1 and v2 patches have diverged, which is why i am not
putting version specific changes in each indivisual patch.
i have created v2 series in a way that the changes feel more organic
and not abrupt.
Only the patch "12/28 remove not needed components" would seem too
invasive. But, as i have noted in patch description, i am not removing
anything which is needed for booting LS1043ARDB as of now. i have done
this to keep the code simple and introduce the components as and when
needed for new features. This makes code review simpler too.
Pankaj Bansal (28):
Silicon/NXP: Add I2c lib
Silicon/NXP: changes to use I2clib in i2cdxe
Silicon/NXP/I2cDxe: Fix I2c Timeout with RTC
Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib
Silicon/Maxim: Add comments in Ds1307RtcLib
NXP/LS1043aRdb: Move Soc specific components to soc files
Silicon/NXP: Implement SerialUartClockLib
Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib
Silicon/NXP: Drop DUartPortLib
Silicon/NXP: remove print information from Soc lib
Silicon/NXP: remove not needed components
Silicon/NXP: Remove unnecessary PCDs
Silicon/NXP: Move dsc file
Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg
Silicon/NXP: Move RAM retrieval from SocLib
Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs
Silicon/NXP: Use Clock retrieval PPI in modules
Silicon/NXP: Add Chassis2 Package
Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg
Silicon/NXP/LS1043A: Move SocLib to Soc Package
Slicon/NXP: Add PlatformPei Lib
NXP/LS1043aRdbPkg/ArmPlatformLib: Use default ArmPlatformHelper.S
NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool
NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit
Platform/NXP: Modify FV rules
Platform/NXP/LS1043aRdbPkg: Add VarStore
Silicon/NXP: move MemoryInitPeiLib as per PEIM structures
Platform/NXP/LS1043aRdbPkg: Add PEI Phase
Platform/NXP/FVRules.fdf.inc | 59 +-
.../Drivers/PlatformDxe/PlatformDxe.c | 15 +-
.../Drivers/PlatformDxe/PlatformDxe.inf | 11 +-
Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 26 +-
Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 21 +-
.../AArch64/ArmPlatformHelper.S | 45 ++
.../ArmPlatformLib.c | 61 +-
.../Library/ArmPlatformLib/ArmPlatformLib.inf | 42 ++
.../ArmPlatformLibMem.c} | 84 ++-
.../Library/PlatformLib/ArmPlatformLib.inf | 55 --
.../Library/PlatformLib/NxpQoriqLsHelper.S | 31 -
Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc | 91 +++
.../Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 23 +-
Silicon/NXP/Chassis2/Chassis2.dec | 23 +
Silicon/NXP/Chassis2/Chassis2.dsc.inc | 10 +
Silicon/NXP/Chassis2/Include/Chassis.h | 34 ++
.../Chassis2/Library/ChassisLib/ChassisLib.c | 97 +++
.../Library/ChassisLib/ChassisLib.inf | 34 ++
Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 533 +---------------
Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 50 +-
Silicon/NXP/Drivers/I2cDxe/I2cDxe.inf | 14 +-
Silicon/NXP/Include/Chassis2/LsSerDes.h | 62 --
Silicon/NXP/Include/Chassis2/NxpSoc.h | 361 -----------
Silicon/NXP/Include/DramInfo.h | 38 --
Silicon/NXP/Include/Library/ChassisLib.h | 51 ++
Silicon/NXP/Include/Library/I2cLib.h | 120 ++++
Silicon/NXP/Include/Library/SocLib.h | 52 ++
Silicon/NXP/Include/Ppi/NxpPlatformGetClock.h | 53 ++
Silicon/NXP/LS1043A/Include/Soc.h | 55 ++
Silicon/NXP/LS1043A/Include/SocSerDes.h | 51 --
Silicon/NXP/LS1043A/LS1043A.dsc.inc | 51 +-
Silicon/NXP/LS1043A/Library/SocLib/SocLib.c | 77 +++
Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf | 27 +
Silicon/NXP/Library/DUartPortLib/DUart.h | 122 ----
.../NXP/Library/DUartPortLib/DUartPortLib.c | 364 -----------
.../NXP/Library/DUartPortLib/DUartPortLib.inf | 34 --
Silicon/NXP/Library/I2cLib/I2cLib.c | 576 ++++++++++++++++++
Silicon/NXP/Library/I2cLib/I2cLib.inf | 31 +
Silicon/NXP/Library/I2cLib/I2cLibInternal.h | 105 ++++
.../Library/MemoryInitPei/MemoryInitPeiLib.c | 140 -----
.../MemoryInitPeiLib/MemoryInitPeiLib.c | 224 +++++++
.../MemoryInitPeiLib/MemoryInitPeiLib.h | 25 +
.../MemoryInitPeiLib.inf | 10 +-
.../Library/PlatformPeiLib/PlatformPeiLib.c | 30 +
.../Library/PlatformPeiLib/PlatformPeiLib.inf | 41 ++
.../SerialUartClockLib/SerialUartClockLib.c | 22 +
.../SerialUartClockLib/SerialUartClockLib.inf | 26 +
Silicon/NXP/Library/SocLib/Chassis.c | 495 ---------------
Silicon/NXP/Library/SocLib/Chassis2/Soc.c | 162 -----
Silicon/NXP/Library/SocLib/LS1043aSocLib.inf | 45 --
Silicon/NXP/Library/SocLib/NxpChassis.h | 136 -----
Silicon/NXP/Library/SocLib/SerDes.c | 268 --------
Silicon/NXP/NxpQoriqLs.dec | 95 +--
{Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc | 74 ++-
54 files changed, 2181 insertions(+), 3201 deletions(-)
create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/AArch64/ArmPlatformHelper.S
rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib => ArmPlatformLib}/ArmPlatformLib.c (51%)
create mode 100644 Platform/NXP/LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.inf
rename Platform/NXP/LS1043aRdbPkg/Library/{PlatformLib/NxpQoriqLsMem.c => ArmPlatformLib/ArmPlatformLibMem.c} (51%)
delete mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf
delete mode 100644 Platform/NXP/LS1043aRdbPkg/Library/PlatformLib/NxpQoriqLsHelper.S
create mode 100644 Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc
create mode 100644 Silicon/NXP/Chassis2/Chassis2.dec
create mode 100644 Silicon/NXP/Chassis2/Chassis2.dsc.inc
create mode 100644 Silicon/NXP/Chassis2/Include/Chassis.h
create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/ChassisLib.c
create mode 100644 Silicon/NXP/Chassis2/Library/ChassisLib/ChassisLib.inf
delete mode 100644 Silicon/NXP/Include/Chassis2/LsSerDes.h
delete mode 100644 Silicon/NXP/Include/Chassis2/NxpSoc.h
delete mode 100644 Silicon/NXP/Include/DramInfo.h
create mode 100644 Silicon/NXP/Include/Library/ChassisLib.h
create mode 100644 Silicon/NXP/Include/Library/I2cLib.h
create mode 100644 Silicon/NXP/Include/Library/SocLib.h
create mode 100644 Silicon/NXP/Include/Ppi/NxpPlatformGetClock.h
create mode 100644 Silicon/NXP/LS1043A/Include/Soc.h
delete mode 100644 Silicon/NXP/LS1043A/Include/SocSerDes.h
create mode 100644 Silicon/NXP/LS1043A/Library/SocLib/SocLib.c
create mode 100644 Silicon/NXP/LS1043A/Library/SocLib/SocLib.inf
delete mode 100644 Silicon/NXP/Library/DUartPortLib/DUart.h
delete mode 100644 Silicon/NXP/Library/DUartPortLib/DUartPortLib.c
delete mode 100644 Silicon/NXP/Library/DUartPortLib/DUartPortLib.inf
create mode 100644 Silicon/NXP/Library/I2cLib/I2cLib.c
create mode 100644 Silicon/NXP/Library/I2cLib/I2cLib.inf
create mode 100644 Silicon/NXP/Library/I2cLib/I2cLibInternal.h
delete mode 100644 Silicon/NXP/Library/MemoryInitPei/MemoryInitPeiLib.c
create mode 100644 Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.c
create mode 100644 Silicon/NXP/Library/MemoryInitPeiLib/MemoryInitPeiLib.h
rename Silicon/NXP/Library/{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.inf (74%)
create mode 100644 Silicon/NXP/Library/PlatformPeiLib/PlatformPeiLib.c
create mode 100644 Silicon/NXP/Library/PlatformPeiLib/PlatformPeiLib.inf
create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.c
create mode 100644 Silicon/NXP/Library/SerialUartClockLib/SerialUartClockLib.inf
delete mode 100644 Silicon/NXP/Library/SocLib/Chassis.c
delete mode 100644 Silicon/NXP/Library/SocLib/Chassis2/Soc.c
delete mode 100644 Silicon/NXP/Library/SocLib/LS1043aSocLib.inf
delete mode 100644 Silicon/NXP/Library/SocLib/NxpChassis.h
delete mode 100644 Silicon/NXP/Library/SocLib/SerDes.c
rename {Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc (84%)
--
2.17.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56009): https://edk2.groups.io/g/devel/message/56009
Mute This Topic: https://groups.io/mt/72077437/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list