[edk2-devel] [RFC][PATCH v1] UefiCpuPkg/MpInitLib DXE: Reduce AP status check interval

Ni, Ray ray.ni at intel.com
Mon Mar 23 14:37:32 UTC 2020


> > Laszlo,
> > Adding a PCD means platform integrators need to consider which value to set.
> > Most of the time, they may just use the default PCD value.
> > Then, why not we add the PCD later when a real case is met?
> 
> The patch changes existent behavior; it is not for a newly introduced
> feature.
> 
> Because most platforms are not in the edk2 tree, we don't know what
> platforms could be regressed by increasing the polling frequency
> tenfold. (And remember that the polling action has O(n) cost, where "n"
> is the logical processor count.)
> 
> Under your suggestion, the expression "real case is met" amounts to
> "someone reports a regression" (possibly after the next stable tag,
> even). I don't think that's a good idea.
> In particular, the patch is motivated by RegisterCpuFeaturesLib -- the
> CpuFeaturesInitialize() function -- on some platform(s) that Hao uses.
> But there are platforms that don't use RegisterCpuFeaturesLib, and still
> use MpInitLib.

OK. I agree with your suggestion.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56109): https://edk2.groups.io/g/devel/message/56109
Mute This Topic: https://groups.io/mt/71925352/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-





More information about the edk2-devel-archive mailing list