[edk2-devel] [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

[Bob Feng]

Reviewed-by: : Bob Feng <bob.c.feng at intel.com>

-----Original Message-----
From: Fan, ZhijuX 
Sent: Friday, March 20, 2020 11:58 AM
To: devel at edk2.groups.io
Cc: Feng, Bob C <bob.c.feng at intel.com>; Gao, Liming <liming.gao at intel.com>; Fan, ZhijuX <zhijux.fan at intel.com>
Subject: [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610

We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error.

Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise statements removed proper error messages are shown.

Cc: Bob Feng <bob.c.feng at intel.com>
Cc: Liming Gao <liming.gao at intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan at intel.com>
---
 BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
index 40b448f5b2db..563d91b421ce 100755
--- a/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
+++ b/BaseTools/Source/Python/AutoGen/AutoGenWorker.py
@@ -256,7 +256,6 @@ class AutoGenWorkerInProcess(mp.Process):
                         CacheResult = Ma.CanSkipbyPreMakeCache()
                     except:
                         CacheResult = False
-                        traceback.print_exc(file=sys.stdout)
                         self.feedback_q.put(taskname)
 
                     if CacheResult:
@@ -273,7 +272,6 @@ class AutoGenWorkerInProcess(mp.Process):
                         CacheResult = Ma.CanSkipbyMakeCache()
                     except:
                         CacheResult = False
-                        traceback.print_exc(file=sys.stdout)
                         self.feedback_q.put(taskname)
 
                     if CacheResult:
@@ -285,7 +283,6 @@ class AutoGenWorkerInProcess(mp.Process):
         except Empty:
             pass
         except:
-            traceback.print_exc(file=sys.stdout)
             self.feedback_q.put(taskname)
         finally:
             self.feedback_q.put("Done")
--
2.14.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56122): https://edk2.groups.io/g/devel/message/56122
Mute This Topic: https://groups.io/mt/72093144/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-