[edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: Fix VS2019 UINT32 conversion error

[Laszlo Ersek]

On 03/29/20 15:51, Ard Biesheuvel wrote:
> Building OVMF for X64 with secure boot enabled on VS2019 results in
> the following error:
> 
>   d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
>     error C2220: the following warning is treated as an error
>   d:\a\1\s\OvmfPkg\Library\GenericQemuLoadImageLib\GenericQemuLoadImageLib.c(154):
>     warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data
> 
> Suppress the error by making the cast explicit.
> 
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2636
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> ---
>  OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> index f7f9a205f99d..14c8417d43e7 100644
> --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c
> @@ -151,7 +151,7 @@ QemuLoadKernelImage (
>      //
>      // Drop the terminating NUL, convert to UTF-16.
>      //
> -    KernelLoadedImage->LoadOptionsSize = (CommandLineSize - 1) * 2;
> +    KernelLoadedImage->LoadOptionsSize = (UINT32)((CommandLineSize - 1) * 2);
>    }
>  
>    QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize);
> 

Reviewed-by: Laszlo Ersek <lersek at redhat.com>

Thank you very much!
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56626): https://edk2.groups.io/g/devel/message/56626
Mute This Topic: https://groups.io/mt/72629862/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-