[edk2-devel] [PATCH 0/4] remove generation of EFI properties table

[Ard Biesheuvel]

(adding Jian and Hao)

Thanks for the acks, and apologies for failing to cc the MdeModulePkg
maintainers.

Jian, Hao, do you have any opinion on this series?




On Mon, 30 Mar 2020 at 15:42, Gao, Liming <liming.gao at intel.com> wrote:
>
> Ack-by: Liming Gao <liming.gao at intel.com>
>
> > -----Original Message-----
> > From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Yao, Jiewen
> > Sent: Friday, March 27, 2020 1:01 PM
> > To: Ard Biesheuvel <ard.biesheuvel at linaro.org>; devel at edk2.groups.io
> > Cc: Laszlo Ersek <lersek at redhat.com>; Leif Lindholm <leif at nuviainc.com>; Kinney, Michael D <michael.d.kinney at intel.com>; Ni, Ray
> > <ray.ni at intel.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>
> > Subject: Re: [edk2-devel] [PATCH 0/4] remove generation of EFI properties table
> >
> > Acked-by: Jiewen Yao <Jiewen.yao at intel.com>
> >
> > I cannot remember if there is windows OS still using the properties table.
> > Maybe Microsoft people can comment.
> >
> > If no, I agree we can remove the old code.
> >
> >
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ard.biesheuvel at linaro.org>
> > > Sent: Thursday, March 26, 2020 6:25 PM
> > > To: devel at edk2.groups.io
> > > Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org>; Laszlo Ersek
> > > <lersek at redhat.com>; Leif Lindholm <leif at nuviainc.com>; Kinney, Michael D
> > > <michael.d.kinney at intel.com>; Ni, Ray <ray.ni at intel.com>; Yao, Jiewen
> > > <jiewen.yao at intel.com>; Bret Barkelew <Bret.Barkelew at microsoft.com>
> > > Subject: [PATCH 0/4] remove generation of EFI properties table
> > >
> > > The EFI properties table is broken by design, deprecated, and seems to be
> > > causing confusion as it is unclear to some how it differs from the memory
> > > attributes table (which supersedes it). So let's get rid of the code that
> > > generates it entirely, along with the GUID definitions, PCDs etc.
> > >
> > > Due to how the two implementations are intertwined, patch #2 makes the
> > > minimal changes required to stop producing the table (and to allow patch
> > > #3 to remove the associated definitions from MdePkg). Patch #4 is optional
> > > and merges the code together.
> > >
> > > Cc: Laszlo Ersek <lersek at redhat.com>
> > > Cc: Leif Lindholm <leif at nuviainc.com>
> > > Cc: Michael D Kinney <michael.d.kinney at intel.com>
> > > Cc: Ray Ni <ray.ni at intel.com>
> > > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > > Cc: Bret Barkelew <Bret.Barkelew at microsoft.com>
> > >
> > > Link: https://bugzilla.tianocore.org/show_bug.cgi?id=2633
> > >
> > > Ard Biesheuvel (4):
> > >   OvmfPkg: remove handling of properties table
> > >   MdeModulePkg: disable properties table generation but retain the code
> > >   MdePkg: remove PropertiesTable GUID
> > >   MdeModulePkg/DxeCore: merge properties table routines into MAT
> > >     handling
> > >
> > >  MdeModulePkg/Core/Dxe/DxeMain.h               |    9 -
> > >  MdeModulePkg/Core/Dxe/DxeMain.inf             |    3 -
> > >  MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c       |    1 -
> > >  .../Core/Dxe/Misc/MemoryAttributesTable.c     | 1226 ++++++++++++++-
> > >  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |    1 -
> > >  MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c  | 1373 -----------------
> > >  MdeModulePkg/MdeModulePkg.dec                 |   24 -
> > >  MdeModulePkg/MdeModulePkg.uni                 |   21 -
> > >  MdePkg/Include/Guid/PropertiesTable.h         |   31 -
> > >  MdePkg/MdePkg.dec                             |    3 -
> > >  OvmfPkg/OvmfPkgIa32.dsc                       |    1 -
> > >  OvmfPkg/OvmfPkgIa32X64.dsc                    |    1 -
> > >  OvmfPkg/OvmfPkgX64.dsc                        |    1 -
> > >  OvmfPkg/OvmfXen.dsc                           |    1 -
> > >  OvmfPkg/PlatformPei/Platform.c                |    1 -
> > >  OvmfPkg/PlatformPei/PlatformPei.inf           |    1 -
> > >  16 files changed, 1222 insertions(+), 1476 deletions(-)
> > >  delete mode 100644 MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c
> > >  delete mode 100644 MdePkg/Include/Guid/PropertiesTable.h
> > >
> > > --
> > > 2.17.1
> >
> >
> > 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56678): https://edk2.groups.io/g/devel/message/56678
Mute This Topic: https://groups.io/mt/72560881/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-