[edk2-devel] [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

[Leif Lindholm]

On Tue, Mar 31, 2020 at 10:23:48 +0000, Pankaj Bansal (OSS) wrote:
> > > -/*++
> > > -
> > > -Routine Description:
> > > -
> > > -
> > > -
> > > -Arguments:
> > > -
> > > -  FileHandle  - Handle of the file being invoked.
> > > -  PeiServices - Describes the list of possible PEI Services.
> > > -
> > > -Returns:
> > > -
> > > -  Status -  EFI_SUCCESS if the boot mode could be set
> > > -
> > > ---*/
> > 
> > The above line caused me an unexpected level of excitement this
> > morning, as my "put back the CRs SMTP strips out" script treated the
> > --- as a diff separator.
> > 
> > Now, I *have* seen the use of /*++ --*/ elsewhere in the tree, but
> > this syntax is *not* described in the coding style and should not be
> > used. While this is a delete statement, there is an addition below
> > using the same format. The doxygen tags to use are /** and **/.
> > 
> > Fortunately, I can't spot any of these in the rest of the set.
> > 
> > Please send an updated version of this patch - alone if it's the only
> > patch that needs changes, or with a v4 if such is required.
> 
> I have not received any comments on other patches so far.
> Does that mean all patches are OK (except above)?
> If that is the case, then I can send only this patch after update.
> If some rework is needed for other patches as well, I will send this patch along with other reworked patches in v3.

No, sorry, going through them now.
Had a lot of random interruptions.

I commented on this first because it caused an error when I was
importing the set.

/
    Leif

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56745): https://edk2.groups.io/g/devel/message/56745
Mute This Topic: https://groups.io/mt/72077462/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-