[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h

Dong, Eric eric.dong at intel.com
Wed May 6 01:31:19 UTC 2020


Acked-by: Eric Dong <eric.dong at intel.com>

Hi Laszlo,

I saw you already provided Review-by tag and I can't verify the change, so I don't add comments for this patch.

I will provide Acked-by tag for the similar case next time.

I have pushed this change.

Thanks,
Eric
From: devel at edk2.groups.io [mailto:devel at edk2.groups.io] On Behalf Of Laszlo Ersek
Sent: Wednesday, May 6, 2020 7:22 AM
To: devel at edk2.groups.io; Dong, Eric <eric.dong at intel.com>; Ni, Ray <ray.ni at intel.com>
Cc: Leo Duran <leo.duran at amd.com>
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h

Eric, Ray,

can one of you please approve, and also merge, this patch?

It's been on the list for two weeks now (and you were CC'd). I didn't
want to go ahead and merge it myself without at least an ACK from one of
you.

Thanks
Laszlo

On 04/22/20 18:55, Laszlo Ersek wrote:
> On 04/22/20 00:05, Leo Duran wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2678
>>
>> This patch fixes a file permission issue introduced by accident.
>>
>> Cc: Eric Dong <eric.dong at intel.com<mailto:eric.dong at intel.com>>
>> Cc: Ray Ni <ray.ni at intel.com<mailto:ray.ni at intel.com>>
>> Cc: Laszlo Ersek <lersek at redhat.com<mailto:lersek at redhat.com>>
>> Signed-off-by: Leo Duran <leo.duran at amd.com<mailto:leo.duran at amd.com>>
>> ---
>>  UefiCpuPkg/Library/MpInitLib/MpLib.h | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  mode change 100755 => 100644 UefiCpuPkg/Library/MpInitLib/MpLib.h
>>
>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
>> old mode 100755
>> new mode 100644
>>
>
> Reviewed-by: Laszlo Ersek <lersek at redhat.com<mailto:lersek at redhat.com>>
>
> Thanks, Leo!
> Laszlo
>
>
>
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58671): https://edk2.groups.io/g/devel/message/58671
Mute This Topic: https://groups.io/mt/73191992/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20200506/a68fd0f6/attachment.htm>


More information about the edk2-devel-archive mailing list